Re: [uml-devel] [PATCH] Avoid not intended gdb breakpoints removal

[Jeff Dike <jdike@addtoit.com>]

On Wed, Dec 05, 2007 at 06:53:45PM +0100, Stanislaw Gruszka wrote:
> Sometimes when UML is debugged gdb miss breakpoints.  

> So I do fix for UML,
> it simply do not call clone() with both SIGCHLD and CLONE_VM flags together. 
> Additionally __WALL flag is used for waitpid() to assure not miss clone
> and normal process events.

Woo!  You're my favorite person this week[1].

This has bugged me forever, and I was too scared to go into gdb to
figure out what its problem was.

A couple of comments:
1 - I think I would prefer to use __WCLONE instead of __WALL since
we know what type of process we are creating, and it seems clearer in
the code to say specifically what we want

1a - I think I would like to stick all those waits under some API in
helper.c as we already have an interface for creating children, and as
it stands now, the callers have knowlege about the internal aspects of
child creation that they probably shouldn't.

2 - I want to get this into mainline quickly, and I need a
Signed-off-by: from you before it goes anywhere.


				Jeff

[1] Narrowly beating out John Reiser, who will be my favorite person
of the week that he manages to boot UML under valgrind.

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel