From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown
Date: Sat, 8 Dec 2007 09:17:54 -0500 [thread overview]
Message-ID: <20071208091754.47ccc377@tleilax.poochiereds.net> (raw)
In-Reply-To: <20071208140747.GA11675@infradead.org>
On Sat, 8 Dec 2007 14:07:47 +0000
Christoph Hellwig <hch@infradead.org> wrote:
> > + mutex_lock(&nlmsvc_mutex);
> > + while (atomic_read(&nlmsvc_ref) != 0) {
>
> might be better to do the refcounting outside the thread and use the
> kthread api, which is something we still need to do for lockd anyway.
>
Currently sending a SIGKILL to lockd tells it to drop all of its locks
without exiting. If we change lockd to use kthreads, will we have to
change that to use a different mechanism?
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2007-12-08 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 13:02 [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown Jeff Layton
2007-12-08 14:07 ` Christoph Hellwig
2007-12-08 14:17 ` Jeff Layton [this message]
2007-12-13 14:40 ` Jeff Layton
2007-12-13 15:24 ` Trond Myklebust
2007-12-13 15:24 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071208091754.47ccc377@tleilax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.