All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown
Date: Sat, 8 Dec 2007 14:07:47 +0000	[thread overview]
Message-ID: <20071208140747.GA11675@infradead.org> (raw)
In-Reply-To: <1197118932-4512-1-git-send-email-jlayton@redhat.com>

> +	mutex_lock(&nlmsvc_mutex);
> +	while (atomic_read(&nlmsvc_ref) != 0) {

might be better to do the refcounting outside the thread and use the
kthread api, which is something we still need to do for lockd anyway.


  reply	other threads:[~2007-12-08 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-08 13:02 [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown Jeff Layton
2007-12-08 14:07 ` Christoph Hellwig [this message]
2007-12-08 14:17   ` Jeff Layton
2007-12-13 14:40   ` Jeff Layton
2007-12-13 15:24     ` Trond Myklebust
2007-12-13 15:24       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071208140747.GA11675@infradead.org \
    --to=hch@infradead.org \
    --cc=jlayton@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.