Re: [PATCH] ath5k: add debugfs entries for registers, tsf, beacon, reset

[bruno randolf <bruno@thinktube.com>]

On Monday 10 December 2007 18:03:19 Jiri Slaby wrote:
> > +static int open_file_registers(struct inode *inode, struct file *file)
> > +{
> > +	struct seq_file *s;
> > +	int res;
> > +	res = seq_open(file, &register_seq_ops);
> > +	s = file->private_data;
> > +	s->private = inode->i_private;
>
> Sorry for not noticing this earlier, if res is nonzero, you are
> dereferencing NULL (s) here.

oh, sorry for not realizing that myself. so i add:

+       if (res == 0) {
+               s = file->private_data;
+               s->private = inode->i_private;
+       }

and resend.

thanks,
bruno