From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: New module to detect vmware
Date: Wed, 12 Dec 2007 15:36:08 +0100 [thread overview]
Message-ID: <20071212143608.GB6180@thorin> (raw)
In-Reply-To: <200712061419.25555.>
On Thu, Dec 06, 2007 at 02:19:25PM +0100, Martin Haaß wrote:
> Hi all!
> I tried to build a module to detect vmware. Attached is the module and a test
> grub.cfg
> It is basically working though I have some questions:
>
> can i use the return value of the function (e.g. vmware_detect) to give back a
> value or am I supposed to always return something like GRUB_ERR_NONE?
>
> is there a script to add a module to the makefile or do I have to copy/paste
> it?
>
> if I use this:
> if vmware_detect = 1; then set foo=1 else set foo=0 fi
> I get syntax error and unknown command in an infinite loop is this expected?
> It should not be a problem with my module, as it also happend while testing a
> environment variable.
> So, is it a problem with my if-syntax?
As per GCS, it'd be better if this avoided referring to a propietary product
more than necessary for the functionality. How about making this a generic
detection command (with a similar interface to the cpuid one), such that
detection for other virtual environments (e.g. qemu) can potentially be
added?
> * VMWARE detection code taken from
> * http://chitchat.at.infoseek.co.jp/vmware/backdoor.html
Is there any copyright-significant code taken from there? Which license?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
prev parent reply other threads:[~2007-12-12 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 13:19 New module to detect vmware Martin Haaß
2007-12-12 14:36 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212143608.GB6180@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.