Re: [PATCH] Move NTFS compression support to new module ntfscomp

[Robert Millan <rmh@aybabtu.com>]

On Fri, Nov 30, 2007 at 02:58:11AM +0800, Bean wrote:
> Hi,
> 
> This patch move NTFS compression function to a standalone module
> ntfscomp. To access NTFS compression file, you just need to load
> ntfscomp dynamically:
> 
> insmod ntfscomp
> 
> Compression support is not needed most of the time. In some situation,
> the size of kernel image is limited (like rom), and it's nice to be
> able to shrink the over-sized ntfs module.

Nice.

I see that you made some unrelated corrections in your patch, e.g.:

-  unsigned us;
+  grub_uint16_t us;

could you include these in ChangeLog ?

Also, would be nice if you could use inline attachment for patches in the
future (I hope it's not a nuissance; I ask because this makes it easier to
make context replies).

Thank you

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)