All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [MTD][OneNAND] Use the u_char instead of char in oobbuf
@ 2007-12-13  2:49 Sheng Yongjie
  0 siblings, 0 replies; only message in thread
From: Sheng Yongjie @ 2007-12-13  2:49 UTC (permalink / raw)
  To: linux-mtd; +Cc: dwmw2

In function onenand_verify_oob, local variable oobbuf shall be unsigned char.

In the case of a value is >= 0x80, it's unequal in comparing the value in an unsigned char and signed char.

Signed-off-by: Sheng Yongjie (Sam) <samsheng@trident.com.cn>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/mtd/onenand/onenand_base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index f2bb276..52cce5c 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -1217,7 +1217,7 @@ int onenand_bbt_read_oob(struct mtd_info *mtd, loff_t from,
 static int onenand_verify_oob(struct mtd_info *mtd, const u_char *buf, loff_t to)
 {
 	struct onenand_chip *this = mtd->priv;
-	char oobbuf[64];
+	u_char oobbuf[64];
 	int status, i;
 
 	this->command(mtd, ONENAND_CMD_READOOB, to, mtd->oobsize);
-- 
1.5.0.6

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-12-13  2:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-13  2:49 [PATCH] [MTD][OneNAND] Use the u_char instead of char in oobbuf Sheng Yongjie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.