All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	glommer@gmail.com, tglx@linutronix.de, ehabkost@redhat.com,
	jeremy@goop.org, avi@qumranet.com, anthony@codemonkey.ws,
	virtualization@lists.linux-foundation.org, rusty@rustcorp.com.au,
	ak@suse.de, chrisw@sous-sol.org, rostedt@goodmis.org,
	hpa@zytor.com, zach@vmware.com, roland@redhat.com
Subject: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
Date: Thu, 13 Dec 2007 22:22:21 +0100	[thread overview]
Message-ID: <20071213212221.GA16747@elte.hu> (raw)
In-Reply-To: <20071213205838.GA9649@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> just got the crash below. config attached. Suspects are:
> 
>  Subject: unify struct desc_ptr
>  Subject: unify paravirt pieces of descriptor handling

i've bisected it down to:

 Subject: avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
 From: Glauber de Oliveira Costa <gcosta@redhat.com>

i have removed this patch from x86.git. Btw., note the advantage of 
small deltas, so only your v3->v4 delta patch got reverted instead of 
the whole 19-patch v3 kit ;-)

> could we _please_ use basic tools as vmlinux size comparison and 
> objcompare when unifying, to make sure it's a 100% identity 
> conversion?

case in point, the patch claims:

> > No functional change is made.

but vmlinux before/after size comparison shows:

    text    data     bss     dec     hex filename
 8802894 1224910 3526656 13554460         ced31c vmlinux.before
 8803042 1224910 3526656 13554608         ced3b0 vmlinux.after

	Ingo

  parent reply	other threads:[~2007-12-13 21:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13 14:29 [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss Glauber de Oliveira Costa
2007-12-13 20:28 ` Ingo Molnar
2007-12-13 20:58   ` Ingo Molnar
2007-12-13 20:58     ` Ingo Molnar
2007-12-13 21:22     ` Ingo Molnar
2007-12-13 21:22     ` Ingo Molnar [this message]
2007-12-13 21:26       ` H. Peter Anvin
2007-12-13 21:26         ` H. Peter Anvin
2007-12-13 21:35         ` Ingo Molnar
2007-12-13 21:35         ` Ingo Molnar
2007-12-13 21:40           ` H. Peter Anvin
2007-12-13 21:40             ` H. Peter Anvin
2007-12-13 21:51             ` Glauber de Oliveira Costa
2007-12-13 21:51             ` Glauber de Oliveira Costa
2007-12-13 21:37         ` Tom Spink
2007-12-13 21:37         ` Tom Spink
2007-12-13 21:40           ` Glauber de Oliveira Costa
2007-12-13 21:40           ` Glauber de Oliveira Costa
2007-12-13 20:28 ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2007-12-13 14:29 Glauber de Oliveira Costa
2007-12-13 19:25 Glauber de Oliveira Costa
2007-12-13 19:25 ` Glauber de Oliveira Costa
2007-12-14 10:43 ` Ingo Molnar
2007-12-14 10:43 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071213212221.GA16747@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=anthony@codemonkey.ws \
    --cc=avi@qumranet.com \
    --cc=chrisw@sous-sol.org \
    --cc=ehabkost@redhat.com \
    --cc=gcosta@redhat.com \
    --cc=glommer@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.