From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: ehabkost@redhat.com, linux-kernel@vger.kernel.org,
Glauber de Oliveira Costa <gcosta@redhat.com>,
chrisw@sous-sol.org, anthony@codemonkey.ws,
akpm@linux-foundation.org,
virtualization@lists.linux-foundation.org, tglx@linutronix.de,
roland@redhat.com, ak@suse.de
Subject: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
Date: Thu, 13 Dec 2007 13:40:55 -0800 [thread overview]
Message-ID: <4761A6E7.7030602@zytor.com> (raw)
In-Reply-To: <20071213213517.GA25563@elte.hu>
Ingo Molnar wrote:
>> Well, "no functional changes" is not quite the same thing as "no
>> object code changes".
>
> yeah, true, but the safest way to ensure no functional changes is to get
> identical object code. In sched-devel.git i include obj comparisons to
> cleanup patches as a self-assurance (and later bughunt helper) to make
> sure a cleanup is really just a cleanup.
Of course. "No object code changes" is a stronger statement, however,
not all types of cleanups result in that.
It's highly useful when applied appropriately, though. In particular,
the programmer should know when object code changes are expected.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Glauber de Oliveira Costa <gcosta@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
glommer@gmail.com, tglx@linutronix.de, ehabkost@redhat.com,
jeremy@goop.org, avi@qumranet.com, anthony@codemonkey.ws,
virtualization@lists.linux-foundation.org, rusty@rustcorp.com.au,
ak@suse.de, chrisw@sous-sol.org, rostedt@goodmis.org,
zach@vmware.com, roland@redhat.com
Subject: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss
Date: Thu, 13 Dec 2007 13:40:55 -0800 [thread overview]
Message-ID: <4761A6E7.7030602@zytor.com> (raw)
In-Reply-To: <20071213213517.GA25563@elte.hu>
Ingo Molnar wrote:
>> Well, "no functional changes" is not quite the same thing as "no
>> object code changes".
>
> yeah, true, but the safest way to ensure no functional changes is to get
> identical object code. In sched-devel.git i include obj comparisons to
> cleanup patches as a self-assurance (and later bughunt helper) to make
> sure a cleanup is really just a cleanup.
Of course. "No object code changes" is a stronger statement, however,
not all types of cleanups result in that.
It's highly useful when applied appropriately, though. In particular,
the programmer should know when object code changes are expected.
-hpa
next prev parent reply other threads:[~2007-12-13 21:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 14:29 [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss Glauber de Oliveira Costa
2007-12-13 20:28 ` Ingo Molnar
2007-12-13 20:28 ` Ingo Molnar
2007-12-13 20:58 ` Ingo Molnar
2007-12-13 20:58 ` Ingo Molnar
2007-12-13 21:22 ` Ingo Molnar
2007-12-13 21:22 ` Ingo Molnar
2007-12-13 21:26 ` H. Peter Anvin
2007-12-13 21:26 ` H. Peter Anvin
2007-12-13 21:35 ` Ingo Molnar
2007-12-13 21:40 ` H. Peter Anvin [this message]
2007-12-13 21:40 ` H. Peter Anvin
2007-12-13 21:51 ` Glauber de Oliveira Costa
2007-12-13 21:51 ` Glauber de Oliveira Costa
2007-12-13 21:35 ` Ingo Molnar
2007-12-13 21:37 ` Tom Spink
2007-12-13 21:40 ` Glauber de Oliveira Costa
2007-12-13 21:40 ` Glauber de Oliveira Costa
2007-12-13 21:37 ` Tom Spink
-- strict thread matches above, loose matches on Subject: below --
2007-12-13 14:29 Glauber de Oliveira Costa
2007-12-13 19:25 Glauber de Oliveira Costa
2007-12-13 19:25 ` Glauber de Oliveira Costa
2007-12-14 10:43 ` Ingo Molnar
2007-12-14 10:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4761A6E7.7030602@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=ehabkost@redhat.com \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.