From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org, avorontsov@ru.mvista.com
Cc: Scott Wood <scottwood@freescale.com>,
linux-mtd@lists.infradead.org, dwmw2@infradead.org
Subject: Re: [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.
Date: Fri, 14 Dec 2007 22:40:48 +0100 [thread overview]
Message-ID: <200712142240.50379.arnd@arndb.de> (raw)
In-Reply-To: <20071214195917.GA18616@localhost.localdomain>
On Friday 14 December 2007, Anton Vorontsov wrote:
> > >Maybe this desires its own header?
> >
> > It can be factored out if anything else ever uses it.
>
> It's just confusing to parse lbc-specific and nand-specific code
> placed in the same file.
In that case, you could argue for splitting the implementation into
two C files. I don't see any reason to move stuff into a header
when it's not an interface between two parts of the code, but
only describes a hardware interface used by a single driver.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org, avorontsov@ru.mvista.com
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org
Subject: Re: [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.
Date: Fri, 14 Dec 2007 22:40:48 +0100 [thread overview]
Message-ID: <200712142240.50379.arnd@arndb.de> (raw)
In-Reply-To: <20071214195917.GA18616@localhost.localdomain>
On Friday 14 December 2007, Anton Vorontsov wrote:
> > >Maybe this desires its own header?
> >
> > It can be factored out if anything else ever uses it.
>
> It's just confusing to parse lbc-specific and nand-specific code
> placed in the same file.
In that case, you could argue for splitting the implementation into
two C files. I don't see any reason to move stuff into a header
when it's not an interface between two parts of the code, but
only describes a hardware interface used by a single driver.
Arnd <><
next prev parent reply other threads:[~2007-12-14 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 18:56 [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support Scott Wood
2007-12-14 19:24 ` Anton Vorontsov
2007-12-14 19:33 ` Scott Wood
2007-12-14 19:59 ` Anton Vorontsov
2007-12-14 21:40 ` Arnd Bergmann [this message]
2007-12-14 21:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712142240.50379.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=avorontsov@ru.mvista.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.