All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc-dev@ozlabs.org, dwmw2@infradead.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 4/4] Freescale enhanced Local Bus Controller FCM NAND support.
Date: Fri, 14 Dec 2007 19:23:21 -0600	[thread overview]
Message-ID: <20071215012321.GJ28696@localdomain> (raw)
In-Reply-To: <20071214190819.29cbe0bb@vader.jdub.homelinux.org>

Josh Boyer wrote:
> On Fri, 14 Dec 2007 16:17:36 -0600
> Scott Wood <scottwood@freescale.com> wrote:
>
> > +	child = NULL;
> > +	while ((child = of_get_next_child(ofdev->node, child)))
> > +		if (of_device_is_compatible(child, "fsl,elbc-fcm-nand"))
> > +			fsl_elbc_chip_probe(ctrl, child);
> 
> Don't you need some of_node_put calls here?

The of_... iterators do of_node_put() for you as long as you don't
break out of the loop early.

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <ntl@pobox.com>
To: Josh Boyer <jwboyer@gmail.com>
Cc: linuxppc-dev@ozlabs.org, dwmw2@infradead.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 4/4] Freescale enhanced Local Bus Controller FCM NAND support.
Date: Fri, 14 Dec 2007 19:23:21 -0600	[thread overview]
Message-ID: <20071215012321.GJ28696@localdomain> (raw)
In-Reply-To: <20071214190819.29cbe0bb@vader.jdub.homelinux.org>

Josh Boyer wrote:
> On Fri, 14 Dec 2007 16:17:36 -0600
> Scott Wood <scottwood@freescale.com> wrote:
>
> > +	child = NULL;
> > +	while ((child = of_get_next_child(ofdev->node, child)))
> > +		if (of_device_is_compatible(child, "fsl,elbc-fcm-nand"))
> > +			fsl_elbc_chip_probe(ctrl, child);
> 
> Don't you need some of_node_put calls here?

The of_... iterators do of_node_put() for you as long as you don't
break out of the loop early.

  reply	other threads:[~2007-12-15  1:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 22:17 [PATCH v3 4/4] Freescale enhanced Local Bus Controller FCM NAND support Scott Wood
2007-12-14 22:17 ` Scott Wood
2007-12-15  1:08 ` Josh Boyer
2007-12-15  1:23   ` Nathan Lynch [this message]
2007-12-15  1:23     ` Nathan Lynch
2007-12-15  2:58 ` David Gibson
2007-12-15  3:50   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071215012321.GJ28696@localdomain \
    --to=ntl@pobox.com \
    --cc=dwmw2@infradead.org \
    --cc=jwboyer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.