All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>
Subject: Re: [Qemu-devel] [PATCH 2/2 v2][UPDATED] Direct IDE I/O
Date: Tue, 18 Dec 2007 00:03:48 +0000	[thread overview]
Message-ID: <200712180003.49328.paul@codesourcery.com> (raw)
In-Reply-To: <47670010.6090409@bellard.org>

On Monday 17 December 2007, Fabrice Bellard wrote:
> Laurent Vivier wrote:
> > This patch enhances the "-drive ,cache=off" mode with IDE drive emulation
> > by removing the buffer used in the IDE emulation.
> > ---
> >  block.c     |   10 +++
> >  block.h     |    2
> >  block_int.h |    1
> >  cpu-all.h   |    1
> >  exec.c      |   19 ++++++
> >  hw/ide.c    |  176
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- vl.c       
> > |    1
> >  7 files changed, 204 insertions(+), 6 deletions(-)
> > [...]
>
> Unfortunately it is more complicated to write to the CPU memory. In
> particular, specific action should be done when translated code is
> present. A consistent API must include something like cpu_page_lock() /
> unlock(). Look at cpu_physical_memory_rw() to see the various issues
> which must be handled. Moreover, it would be better to add bus specific
> APIs (at least for PCI), but I can accept a CPU memory API for now.

In general it may also be unsafe to do async writes directly to guest memory 
because you break the atomicity of loads/stores.

Paul

  reply	other threads:[~2007-12-18  0:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 22:09 [Qemu-devel] [PATCH 0/2 v2][UPDATED] Open disk images with O_DIRECT Laurent Vivier
2007-12-17 22:09 ` [Qemu-devel] [PATCH 1/2 v2][UPDATE] Add "cache" parameter to "-drive" Laurent Vivier
2007-12-17 22:09   ` [Qemu-devel] [PATCH 2/2 v2][UPDATED] Direct IDE I/O Laurent Vivier
2007-12-17 23:02     ` Fabrice Bellard
2007-12-18  0:03       ` Paul Brook [this message]
2007-12-18  9:55         ` Laurent Vivier
2007-12-18 16:38         ` Avi Kivity
2007-12-17 23:08   ` [Qemu-devel] [PATCH 1/2 v2][UPDATE] Add "cache" parameter to "-drive" Fabrice Bellard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712180003.49328.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.