From: Fabrice Bellard <fabrice@bellard.org>
To: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2 v2][UPDATE] Add "cache" parameter to "-drive"
Date: Tue, 18 Dec 2007 00:08:50 +0100 [thread overview]
Message-ID: <47670182.6070908@bellard.org> (raw)
In-Reply-To: <11979293583970@bull.net>
Laurent Vivier wrote:
> This patch adds a new parameter to "-drive"
>
> Using "cache=off" with "-drive" will open the disk image file using
> "O_DIRECT".
>
> By default, "cache" is set to "on" to keep original behavior of qemu.
>
> example:
>
> "-drive file=my_disk.qcow2,cache=off"
> ---
> block-raw-posix.c | 8 ++++++++
> block-raw-win32.c | 4 ++++
> block.c | 2 +-
> block.h | 1 +
> hw/fdc.c | 7 ++++++-
> hw/ide.c | 18 ++++++++++++++----
> hw/scsi-disk.c | 3 ++-
> hw/sd.c | 11 ++++++++++-
> osdep.c | 20 ++++++++++++++++++++
> osdep.h | 1 +
> vl.c | 28 ++++++++++++++++++++++++----
> 11 files changed, 91 insertions(+), 12 deletions(-)
> [...]
I suggest trying to remove the malloc/free which are done at every
blk_read/write for sd.c.
Fabrice.
prev parent reply other threads:[~2007-12-17 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 22:09 [Qemu-devel] [PATCH 0/2 v2][UPDATED] Open disk images with O_DIRECT Laurent Vivier
2007-12-17 22:09 ` [Qemu-devel] [PATCH 1/2 v2][UPDATE] Add "cache" parameter to "-drive" Laurent Vivier
2007-12-17 22:09 ` [Qemu-devel] [PATCH 2/2 v2][UPDATED] Direct IDE I/O Laurent Vivier
2007-12-17 23:02 ` Fabrice Bellard
2007-12-18 0:03 ` Paul Brook
2007-12-18 9:55 ` Laurent Vivier
2007-12-18 16:38 ` Avi Kivity
2007-12-17 23:08 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47670182.6070908@bellard.org \
--to=fabrice@bellard.org \
--cc=Laurent.Vivier@bull.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.