All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Damien Wyart <damien.wyart@free.fr>
Cc: David Chinner <dgc@sgi.com>,
	Christoph Hellwig <hch@infradead.org>,
	Lachlan McIlroy <lachlan@sgi.com>, Peter Leckie <pleckie@sgi.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-xfs@oss.sgi.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Important regression with XFS update for 2.6.24-rc6
Date: Wed, 19 Dec 2007 22:31:12 +1100	[thread overview]
Message-ID: <20071219113112.GD4612@sgi.com> (raw)
In-Reply-To: <87r6hjaq7p.fsf@free.fr>

On Wed, Dec 19, 2007 at 12:17:30PM +0100, Damien Wyart wrote:
> * David Chinner <dgc@sgi.com> [071219 11:45]:
> > Can someone pass me a brown paper bag, please?
> 
> My first impression on this bug was not so wrong, after all ;-)
> 
> > That also explains why we haven't seen it - it requires the user buffer to
> > fill on the first entry of a backing buffer and so it is largely dependent
> > on the pattern of name lengths, page size and filesystem block size
> > aligning just right to trigger the problem.
> 
> I guess I was lucky to trigger it quite easily...
> 
> > Can you test this patch, Damien?
> 
> Works fine, all the bad symptoms have disappeared and strace output is
> normal.
> 
> So you can add:
> 
> Tested-by: Damien Wyart <damien.wyart@free.fr>

Thanks for reporting the bug and testing the fix so quickly, Damien.
I'll give it some more QA before I push it, though.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  reply	other threads:[~2007-12-19 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 11:28 Important regression with XFS update for 2.6.24-rc6 Damien Wyart
2007-12-18 12:24 ` David Chinner
2007-12-18 14:30   ` Damien Wyart
2007-12-18 15:19     ` David Chinner
2007-12-19 10:45       ` David Chinner
2007-12-19 11:17         ` Damien Wyart
2007-12-19 11:31           ` David Chinner [this message]
2007-12-20  1:56         ` [review please] " David Chinner
2007-12-20  5:01           ` Timothy Shimmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071219113112.GD4612@sgi.com \
    --to=dgc@sgi.com \
    --cc=damien.wyart@free.fr \
    --cc=hch@infradead.org \
    --cc=lachlan@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=pleckie@sgi.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.