From: David Miller <davem@davemloft.net>
To: m.kozlowski@tuxland.pl
Cc: mpm@selenic.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags
Date: Fri, 21 Dec 2007 00:17:26 +0000 [thread overview]
Message-ID: <20071220.161726.68534356.davem@davemloft.net> (raw)
In-Reply-To: <200712202047.56745.m.kozlowski@tuxland.pl>
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Thu, 20 Dec 2007 20:47:55 +0100
> [ 145.128915] TSTATE: 0000004411009603 TPC: 00000000005119ac TNPC: 00000000005119b0 Y: 00000000 Not tainted
> [ 145.128940] TPC: <kpagecount_read+0x94/0xe0>
My suspicion at this point is that with certain RAM layouts, simply
iterating over PFN's is simply not working out.
pfn_to_page() seems to be doing no range checking, and with sparsemem
vmemmap, which sparc64 always uses, this can be problematic.
It just blindly goes "vmemmap + pfn" which is asking for trouble, in
particular when the physical RAM layout really is sparse.
Maybe it's enough to add a pfn_valid() check here? If pfn_valid()
means there is a vmemmap translation setup for that page struct too,
it would work.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: m.kozlowski@tuxland.pl
Cc: mpm@selenic.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags
Date: Thu, 20 Dec 2007 16:17:26 -0800 (PST) [thread overview]
Message-ID: <20071220.161726.68534356.davem@davemloft.net> (raw)
In-Reply-To: <200712202047.56745.m.kozlowski@tuxland.pl>
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Thu, 20 Dec 2007 20:47:55 +0100
> [ 145.128915] TSTATE: 0000004411009603 TPC: 00000000005119ac TNPC: 00000000005119b0 Y: 00000000 Not tainted
> [ 145.128940] TPC: <kpagecount_read+0x94/0xe0>
My suspicion at this point is that with certain RAM layouts, simply
iterating over PFN's is simply not working out.
pfn_to_page() seems to be doing no range checking, and with sparsemem
vmemmap, which sparc64 always uses, this can be problematic.
It just blindly goes "vmemmap + pfn" which is asking for trouble, in
particular when the physical RAM layout really is sparse.
Maybe it's enough to add a pfn_valid() check here? If pfn_valid()
means there is a vmemmap translation setup for that page struct too,
it would work.
next prev parent reply other threads:[~2007-12-21 0:17 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 10:40 2.6.24-rc5-mm1 Andrew Morton
2007-12-13 11:59 ` 2.6.24-rc5-mm1 kobject changes broken with hvcs driver on powerpc - regression Kamalesh Babulal
2007-12-13 16:22 ` Greg KH
2007-12-13 12:28 ` 2.6.24-rc5-mm1 Gautham R Shenoy
2007-12-13 21:15 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-14 9:49 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-14 13:15 ` 2.6.24-rc5-mm1 Gregory Haskins
2007-12-13 14:18 ` 2.6.24-rc5-mm1 Pierre Peiffer
2007-12-13 15:01 ` 2.6.24-rc5-mm1 Benjamin Thery
2007-12-13 16:07 ` 2.6.24-rc5-mm1 Borislav Petkov
2007-12-13 16:07 ` 2.6.24-rc5-mm1 Borislav Petkov
2007-12-13 17:54 ` 2.6.24-rc5-mm1 Adrian Bunk
2007-12-13 17:54 ` 2.6.24-rc5-mm1 Adrian Bunk
2007-12-13 17:45 ` 2.6.24-rc5-mm1 David Miller
2007-12-14 2:08 ` 2.6.24-rc5-mm1 Herbert Xu
2007-12-14 19:26 ` 2.6.24-rc5-mm1 David Miller
2007-12-13 14:56 ` 2.6.24-rc5-mm1 regression - kernel warning on tcp_fastretrans_alert() Kamalesh Babulal
2007-12-13 19:55 ` Andrew Morton
2007-12-13 15:16 ` 2.6.24-rc5-mm1 - build failures due to kobject changes Kamalesh Babulal
2007-12-13 16:21 ` Greg KH
2007-12-13 17:46 ` (was Re: 2.6.24-rc5-mm1) crypto/authenc.c select symbol in Kconfig Borislav Petkov
2007-12-14 8:53 ` Herbert Xu
2007-12-14 5:32 ` 2.6.24-rc5-mm1 Dave Young
2007-12-14 15:44 ` 2.6.24-rc5-mm1 Alan Stern
2007-12-17 1:14 ` 2.6.24-rc5-mm1 Dave Young
2007-12-19 7:49 ` 2.6.24-rc5-mm1 Dave Young
2007-12-19 16:07 ` 2.6.24-rc5-mm1 Alan Stern
2007-12-20 0:43 ` 2.6.24-rc5-mm1 Dave Young
2007-12-20 3:34 ` 2.6.24-rc5-mm1 Alan Stern
2007-12-20 4:32 ` 2.6.24-rc5-mm1 Dave Young
2007-12-14 14:08 ` 2.6.24-rc5-mm1 Dhaval Giani
2007-12-15 19:20 ` 2.6.24-rc5-mm1 Alexey Dobriyan
2007-12-16 9:10 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-15 23:59 ` broken suspend, sometimes (drm related) [Was: 2.6.24-rc5-mm1] Jiri Slaby
2007-12-16 18:45 ` [PATCH 1/2] DRM: i915, suspend oops fix Jiri Slaby
2007-12-16 18:45 ` [PATCH 2/2] DRM: i915, fix oops after killing X Jiri Slaby
2007-12-17 16:55 ` broken suspend, sometimes (drm related) [Was: 2.6.24-rc5-mm1] Jesse Barnes
2007-12-17 16:55 ` Jesse Barnes
2007-12-15 23:59 ` Jiri Slaby
2007-12-16 0:18 ` 2.6.24-rc5-mm1: cat /proc/net/packet -> oops Mariusz Kozlowski
2007-12-16 3:07 ` Herbert Xu
2007-12-16 3:41 ` [PACKET]: Fix /proc/net/packet crash due to bogus private pointer Herbert Xu
2007-12-16 10:48 ` Mariusz Kozlowski
2007-12-16 22:04 ` David Miller
2007-12-16 10:11 ` 2.6.24-rc5-mm1: problems with cat /proc/kpageflags Mariusz Kozlowski
2007-12-16 10:14 ` Mariusz Kozlowski
2007-12-16 10:41 ` Mariusz Kozlowski
2007-12-16 10:41 ` Mariusz Kozlowski
2007-12-16 11:40 ` Mariusz Kozlowski
2007-12-16 11:40 ` Mariusz Kozlowski
2007-12-16 18:27 ` Matt Mackall
2007-12-16 18:27 ` Matt Mackall
2007-12-16 18:48 ` Mariusz Kozlowski
2007-12-16 18:48 ` Mariusz Kozlowski
2007-12-16 19:10 ` Mariusz Kozlowski
2007-12-16 19:10 ` Mariusz Kozlowski
2007-12-17 2:11 ` Matt Mackall
2007-12-17 2:11 ` Matt Mackall
2007-12-17 4:26 ` David Miller
2007-12-17 4:26 ` David Miller
2007-12-17 6:39 ` Andrew Morton
2007-12-17 6:39 ` Andrew Morton
2007-12-17 14:55 ` Matt Mackall
2007-12-17 14:55 ` Matt Mackall
2007-12-20 12:53 ` David Miller
2007-12-20 12:53 ` David Miller
2007-12-20 17:45 ` Matt Mackall
2007-12-20 17:45 ` Matt Mackall
2007-12-20 19:47 ` Mariusz Kozlowski
2007-12-20 19:47 ` Mariusz Kozlowski
2007-12-21 0:17 ` David Miller [this message]
2007-12-21 0:17 ` David Miller
2007-12-21 1:06 ` Matt Mackall
2007-12-21 1:06 ` Matt Mackall
2007-12-21 3:15 ` David Miller
2007-12-21 3:15 ` David Miller
2007-12-21 21:51 ` Mariusz Kozlowski
2007-12-21 21:51 ` Mariusz Kozlowski
2007-12-22 5:00 ` Andrew Morton
2007-12-22 5:00 ` Andrew Morton
2007-12-17 19:05 ` Mariusz Kozlowski
2007-12-17 19:05 ` Mariusz Kozlowski
2007-12-17 22:44 ` 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior Valdis.Kletnieks
2007-12-17 22:56 ` Andrew Morton
2007-12-18 2:07 ` Valdis.Kletnieks
2007-12-18 2:37 ` Dave Young
2007-12-18 2:52 ` Andrew Morton
2007-12-19 1:22 ` David Howells
2007-12-19 1:33 ` Dave Young
2007-12-19 2:04 ` Andrew Morton
2007-12-19 3:30 ` Jeff Dike
2007-12-18 5:52 ` Valdis.Kletnieks
2007-12-18 6:10 ` 2.6.24-rc5-mm1 - IPv6 throws section mismatches Valdis.Kletnieks
2007-12-18 15:12 ` Daniel Lezcano
2007-12-20 16:55 ` 2.6.24-rc5-mm1 Jason Wessel
2007-12-20 23:11 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-21 13:46 ` 2.6.24-rc5-mm1 Jason Wessel
2007-12-20 20:57 ` 2.6.24-rc5-mm1 - SCSI/blkdev probing hang Rik van Riel
2007-12-20 21:22 ` Andrew Morton
2007-12-24 15:12 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220.161726.68534356.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=mpm@selenic.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.