* [PATCH 1/8] Remove unnecessary comments to ccids code
@ 2007-12-20 16:58 Leandro
2007-12-20 19:34 ` Ian McDonald
2007-12-21 8:57 ` Gerrit Renker
0 siblings, 2 replies; 3+ messages in thread
From: Leandro @ 2007-12-20 16:58 UTC (permalink / raw)
To: dccp
[CCIDS] Remove unnecessary comments to ccids code
This patch removes some unnecessary files header comments. This was suggested by Arnaldo. According to Arnaldo there is no need to reference the file name in the header comments. It also commit the misspelling of copyright in ccid-4 code, reported by Ian. Note that this patches just apply to ccids code, not for the hole DCCP code.
Signed-off-by: Leandro Melo de Sales <leandro@embedded.ufcg.edu.br>
Index: ccid4/net/dccp/ccids/ccid2.c
=================================--- ccid4.orig/net/dccp/ccids/ccid2.c
+++ ccid4/net/dccp/ccids/ccid2.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/ccid2.c
- *
* Copyright (c) 2005, 2006 Andrea Bittau <a.bittau@cs.ucl.ac.uk>
*
* Changes to meet Linux coding standards, and DCCP infrastructure fixes.
Index: ccid4/net/dccp/ccids/ccid2.h
=================================--- ccid4.orig/net/dccp/ccids/ccid2.h
+++ ccid4/net/dccp/ccids/ccid2.h
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/ccid2.h
- *
* Copyright (c) 2005 Andrea Bittau <a.bittau@cs.ucl.ac.uk>
*
* This program is free software; you can redistribute it and/or modify
Index: ccid4/net/dccp/ccids/ccid3.c
=================================--- ccid4.orig/net/dccp/ccids/ccid3.c
+++ ccid4/net/dccp/ccids/ccid3.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/ccid3.c
- *
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
* Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.
* Copyright (c) 2005-7 Ian McDonald <ian.mcdonald@jandi.co.nz>
Index: ccid4/net/dccp/ccids/ccid3.h
=================================--- ccid4.orig/net/dccp/ccids/ccid3.h
+++ ccid4/net/dccp/ccids/ccid3.h
@@ -1,8 +1,6 @@
#ifndef _DCCP_CCID3_H_
#define _DCCP_CCID3_H_
/*
- * net/dccp/ccids/ccid3.h
- *
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
* Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.
*
Index: ccid4/net/dccp/ccids/ccid4.c
=================================--- ccid4.orig/net/dccp/ccids/ccid4.c
+++ ccid4/net/dccp/ccids/ccid4.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/ccid4.c
- *
* Copyright (c) 2007 Federal University of Campina Grande, Paraiba, BR.
* Copyright (c) 2007 University of Helsinki, Finland.
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
@@ -8,7 +6,7 @@
*
* An implementation of the DCCP protocol
*
- * Copyrithg (c) 2007 Leandro Sales, Tommi Saviranta
+ * Copyright (c) 2007 Leandro Sales, Tommi Saviranta
*
* This code has been developed by the Federal University of Campina Grande
* Embedded Systems and Pervasive Computing Lab and the Department of Computer
@@ -16,7 +14,7 @@
* http://embedded.ufcg.edu.br/ <leandroal@gmail.com>
* http://www.iki.fi/ <wnd@iki.fi>
*
- * Copyrithg (c) 2005-7 Ian McDonald
+ * Copyright (c) 2005-7 Ian McDonald
*
* This code is based on code developed by the University of Waikato WAND
* research group. For further information please see http://www.wand.net.nz/
Index: ccid4/net/dccp/ccids/ccid4.h
=================================--- ccid4.orig/net/dccp/ccids/ccid4.h
+++ ccid4/net/dccp/ccids/ccid4.h
@@ -1,8 +1,6 @@
#ifndef _DCCP_CCID4_H_
#define _DCCP_CCID4_H_
/*
- * net/dccp/ccids/ccid4.c
- *
* Copyright (c) 2007 Federal University of Campina Grande, Paraiba, BR.
* Copyright (c) 2007 University of Helsinki, Finland.
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
@@ -10,7 +8,7 @@
*
* An implementation of the DCCP protocol
*
- * Copyrithg (c) 2007 Leandro Sales, Tommi Saviranta
+ * Copyright (c) 2007 Leandro Sales, Tommi Saviranta
*
* This code has been developed by the Federal University of Campina Grande
* Embedded Systems and Pervasive Computing Lab and the Department of Computer
@@ -18,7 +16,7 @@
* http://embedded.ufcg.edu.br/ <leandroal@gmail.com>
* http://www.iki.fi/ <wnd@iki.fi>
*
- * Copyrithg (c) 2005-7 Ian McDonald
+ * Copyright (c) 2005-7 Ian McDonald
*
* This code is based on code developed by the University of Waikato WAND
* research group. For further information please see http://www.wand.net.nz/
Index: ccid4/net/dccp/ccids/lib/loss_interval.c
=================================--- ccid4.orig/net/dccp/ccids/lib/loss_interval.c
+++ ccid4/net/dccp/ccids/lib/loss_interval.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/lib/loss_interval.c
- *
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
* Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.
* Copyright (c) 2005-7 Ian McDonald <ian.mcdonald@jandi.co.nz>
Index: ccid4/net/dccp/ccids/lib/loss_interval.h
=================================--- ccid4.orig/net/dccp/ccids/lib/loss_interval.h
+++ ccid4/net/dccp/ccids/lib/loss_interval.h
@@ -1,8 +1,6 @@
#ifndef _DCCP_LI_HIST_
#define _DCCP_LI_HIST_
/*
- * net/dccp/ccids/lib/loss_interval.h
- *
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
* Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.
* Copyright (c) 2005-7 Ian McDonald <ian.mcdonald@jandi.co.nz>
Index: ccid4/net/dccp/ccids/lib/packet_history.c
=================================--- ccid4.orig/net/dccp/ccids/lib/packet_history.c
+++ ccid4/net/dccp/ccids/lib/packet_history.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/packet_history.c
- *
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
* Copyright (c) 2005-7 The University of Waikato, Hamilton, New Zealand.
*
Index: ccid4/net/dccp/ccids/lib/tfrc_ccids.c
=================================--- ccid4.orig/net/dccp/ccids/lib/tfrc_ccids.c
+++ ccid4/net/dccp/ccids/lib/tfrc_ccids.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/lib/tfrc_ccids.c
- *
* Copyright (c) 2007 Leandro Melo de Sales <leandroal@gmail.com>
* Copyright (c) 2005 Ian McDonald <ian.mcdonald@jandi.co.nz>
* Copyright (c) 2005 Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Index: ccid4/net/dccp/ccids/lib/tfrc_ccids.h
=================================--- ccid4.orig/net/dccp/ccids/lib/tfrc_ccids.h
+++ ccid4/net/dccp/ccids/lib/tfrc_ccids.h
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/lib/tfrc_ccids.h
- *
* Copyright (c) 2007 Leandro Melo de Sales <leandroal@gmail.com>
* Copyright (c) 2005 Ian McDonald <ian.mcdonald@jandi.co.nz>
* Copyright (c) 2005 Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Index: ccid4/net/dccp/ccids/lib/tfrc_equation.c
=================================--- ccid4.orig/net/dccp/ccids/lib/tfrc_equation.c
+++ ccid4/net/dccp/ccids/lib/tfrc_equation.c
@@ -1,6 +1,4 @@
/*
- * net/dccp/ccids/lib/tfrc_equation.c
- *
* Copyright (c) 2005 The University of Waikato, Hamilton, New Zealand.
* Copyright (c) 2005 Ian McDonald <ian.mcdonald@jandi.co.nz>
* Copyright (c) 2005 Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Index: ccid4/net/dccp/ccids/lib/tfrc.h
=================================--- ccid4.orig/net/dccp/ccids/lib/tfrc.h
+++ ccid4/net/dccp/ccids/lib/tfrc.h
@@ -1,8 +1,6 @@
#ifndef _TFRC_H_
#define _TFRC_H_
/*
- * net/dccp/ccids/lib/tfrc.h
- *
* Copyright (c) 2007 The University of Aberdeen, Scotland, UK
* Copyright (c) 2005-6 The University of Waikato, Hamilton, New Zealand.
* Copyright (c) 2005-6 Ian McDonald <ian.mcdonald@jandi.co.nz>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/8] Remove unnecessary comments to ccids code
2007-12-20 16:58 [PATCH 1/8] Remove unnecessary comments to ccids code Leandro
@ 2007-12-20 19:34 ` Ian McDonald
2007-12-21 8:57 ` Gerrit Renker
1 sibling, 0 replies; 3+ messages in thread
From: Ian McDonald @ 2007-12-20 19:34 UTC (permalink / raw)
To: dccp
On 12/21/07, Leandro <leandroal@gmail.com> wrote:
> [CCIDS] Remove unnecessary comments to ccids code
>
> This patch removes some unnecessary files header comments. This was suggested by Arnaldo. According to Arnaldo there is no need to reference the file name in the header comments. It also commit the misspelling of copyright in ccid-4 code, reported by Ian. Note that this patches just apply to ccids code, not for the hole DCCP code.
>
> Signed-off-by: Leandro Melo de Sales <leandro@embedded.ufcg.edu.br>
>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/8] Remove unnecessary comments to ccids code
2007-12-20 16:58 [PATCH 1/8] Remove unnecessary comments to ccids code Leandro
2007-12-20 19:34 ` Ian McDonald
@ 2007-12-21 8:57 ` Gerrit Renker
1 sibling, 0 replies; 3+ messages in thread
From: Gerrit Renker @ 2007-12-21 8:57 UTC (permalink / raw)
To: dccp
Quoting Leandro:
| [CCIDS] Remove unnecessary comments to ccids code
|
| This patch removes some unnecessary files header comments. This was suggested by Arnaldo. According to Arnaldo there is no need to reference the file name in the header comments. It also commit the misspelling of copyright in ccid-4 code, reported by Ian. Note that this patches just apply to ccids code, not for the hole DCCP code.
|
This patch does not apply on the CCID4 subtree - against which tree are these patches?
In any case, I hope that Arnaldo will consider this for the mainline tree, hence
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-21 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-20 16:58 [PATCH 1/8] Remove unnecessary comments to ccids code Leandro
2007-12-20 19:34 ` Ian McDonald
2007-12-21 8:57 ` Gerrit Renker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.