From: Andy Whitcroft <apw@shadowen.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: axboe@kernel.dk, monstr@monstr.eu, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, sr@denx.de
Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support
Date: Thu, 20 Dec 2007 14:45:32 +0000 [thread overview]
Message-ID: <20071220144532.GA27885@shadowen.org> (raw)
In-Reply-To: <20071220062348.16448.24575.stgit@trillian.secretlab.ca>
On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:
> + /* Make the sysace device 'live' */
> + if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
> + add_disk(ace->gd);
checkpatch.pl reports the above if as suspect due to the trailing ;.
Looks wrong to me too.
WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#296: FILE: drivers/block/xsysace.c:835:
+ if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
+ add_disk(ace->gd);
-apw
WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@shadowen.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, sr@denx.de, monstr@monstr.eu,
jwilliams@itee.uq.edu.au, stephen.neuendorffer@xilinx.com
Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support
Date: Thu, 20 Dec 2007 14:45:32 +0000 [thread overview]
Message-ID: <20071220144532.GA27885@shadowen.org> (raw)
In-Reply-To: <20071220062348.16448.24575.stgit@trillian.secretlab.ca>
On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:
> + /* Make the sysace device 'live' */
> + if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
> + add_disk(ace->gd);
checkpatch.pl reports the above if as suspect due to the trailing ;.
Looks wrong to me too.
WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#296: FILE: drivers/block/xsysace.c:835:
+ if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
+ add_disk(ace->gd);
-apw
next prev parent reply other threads:[~2007-12-20 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 6:23 [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support Grant Likely
2007-12-20 6:30 ` Grant Likely
2007-12-20 14:45 ` Andy Whitcroft [this message]
2007-12-20 14:45 ` Andy Whitcroft
2007-12-20 15:42 ` Grant Likely
2007-12-20 15:42 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220144532.GA27885@shadowen.org \
--to=apw@shadowen.org \
--cc=axboe@kernel.dk \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=monstr@monstr.eu \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.