From: "John W. Linville" <linville@tuxdriver.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] mac80211: remove useless sdata variable
Date: Fri, 21 Dec 2007 09:15:57 -0500 [thread overview]
Message-ID: <20071221141557.GC19874@tuxdriver.com> (raw)
In-Reply-To: <je1w9gp5ll.fsf@sykes.suse.de>
On Fri, Dec 21, 2007 at 01:58:14PM +0100, Andreas Schwab wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> >> Perhaps because it is used?
> >>
> >> > --- everything.orig/net/mac80211/ieee80211_sta.c 2007-12-21 01:02:11.253160428 +0100
> >> > +++ everything/net/mac80211/ieee80211_sta.c 2007-12-21 01:02:32.113165907 +0100
> >> > @@ -458,12 +458,10 @@ static void ieee80211_set_associated(str
> >> > return;
> >> >
> >> > if (assoc) {
> >> > - struct ieee80211_sub_if_data *sdata;
> >
> > Too little context. There's another one in the surrounding scope that is
> > already initialised exactly the same.
>
> Sorry, but I can't find it. Was it added in an unmerged patch?
I think I'm with Andreas here...?
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-12-21 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 0:03 [PATCH] mac80211: remove useless sdata variable Johannes Berg
2007-12-21 12:09 ` Andreas Schwab
2007-12-21 12:34 ` Johannes Berg
2007-12-21 12:58 ` Andreas Schwab
2007-12-21 14:15 ` John W. Linville [this message]
2007-12-21 16:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221141557.GC19874@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.