From: Andreas Schwab <schwab@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] mac80211: remove useless sdata variable
Date: Fri, 21 Dec 2007 13:58:14 +0100 [thread overview]
Message-ID: <je1w9gp5ll.fsf@sykes.suse.de> (raw)
In-Reply-To: <1198240471.16241.70.camel@johannes.berg> (Johannes Berg's message of "Fri\, 21 Dec 2007 13\:34\:31 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
>> Perhaps because it is used?
>>=20
>> > --- everything.orig/net/mac80211/ieee80211_sta.c 2007-12-21 01:02:=
11.253160428 +0100
>> > +++ everything/net/mac80211/ieee80211_sta.c 2007-12-21 01:02:32.11=
3165907 +0100
>> > @@ -458,12 +458,10 @@ static void ieee80211_set_associated(str
>> > return;
>> > =20
>> > if (assoc) {
>> > - struct ieee80211_sub_if_data *sdata;
>
> Too little context. There's another one in the surrounding scope that=
is
> already initialised exactly the same.
Sorry, but I can't find it. Was it added in an unmerged patch?
Andreas.
--=20
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany
PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4=
ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-12-21 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 0:03 [PATCH] mac80211: remove useless sdata variable Johannes Berg
2007-12-21 12:09 ` Andreas Schwab
2007-12-21 12:34 ` Johannes Berg
2007-12-21 12:58 ` Andreas Schwab [this message]
2007-12-21 14:15 ` John W. Linville
2007-12-21 16:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je1w9gp5ll.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.