Re: [PATCH] Fix xend xenstore handling

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Dec 21, 2007 at 03:27:13PM +0000, John Levon wrote:
> On Fri, Dec 21, 2007 at 03:08:03PM +0000, Daniel P. Berrange wrote:
> 
> > > This is the cause of the "reboot loop" xend failures I reported earlier.
> > > Note that I've only tested this patch against 3.1, however the code,
> > > and the fix, is the same in unstable. I realise it's late in the cycle
> > > but this bug is bad enough to need fixing IMHO.
> > 
> > I think the entire code segment from the point at which xstransact() is
> > created needs to be in a try...finally   block to be safe against the
> > code throwing exceptions, otherwise you could very ocassionally get the
> > final xs.abort() being missed in error conditions.
> 
> OK, how about this one? (I'm starting testing it now)

Yep, that looks good to me.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|