From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Kyle McMartin <kyle@mcmartin.ca>,
Roland McGrath <roland@redhat.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf
Date: Fri, 21 Dec 2007 20:36:27 +0100 [thread overview]
Message-ID: <200712212036.29098.arnd@arndb.de> (raw)
In-Reply-To: <20071221175106.GB17656@fattire.cabal.ca>
On Friday 21 December 2007, Kyle McMartin wrote:
> Just taking a stab that hch means,
>
> config BINFMT_COMPAT_ELF
> def_bool n
> depends on 64BIT
>
I'd call it COMPAT_BINFMT_ELF, for consistency with the file name.
Also, the definition and the depends are redundant if you expect the
option to be autoselected. You can do either of
config COMPAT_BINFMT_ELF
bool
or
config COMPAT_BINFMT_ELF
def_bool y
depends on COMPAT
The second option makes sense at the point where all architectures with
compat code are using the same compat_binfmt_elf code.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: linux-arch@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, Kyle McMartin <kyle@mcmartin.ca>,
Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Roland McGrath <roland@redhat.com>
Subject: Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf
Date: Fri, 21 Dec 2007 20:36:27 +0100 [thread overview]
Message-ID: <200712212036.29098.arnd@arndb.de> (raw)
In-Reply-To: <20071221175106.GB17656@fattire.cabal.ca>
On Friday 21 December 2007, Kyle McMartin wrote:
> Just taking a stab that hch means,
>=20
> config BINFMT_COMPAT_ELF
> =A0=A0=A0=A0=A0=A0=A0=A0def_bool n
> =A0=A0=A0=A0=A0=A0=A0=A0depends on 64BIT
>=20
I'd call it COMPAT_BINFMT_ELF, for consistency with the file name.
Also, the definition and the depends are redundant if you expect the
option to be autoselected. You can do either of
config COMPAT_BINFMT_ELF
bool
or=20
config COMPAT_BINFMT_ELF
def_bool y
depends on COMPAT
The second option makes sense at the point where all architectures with
compat code are using the same compat_binfmt_elf code.
Arnd <><
next prev parent reply other threads:[~2007-12-21 19:36 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 11:52 [PATCH -mm 00/43] user_regset framework -- arch maintainers take note! Roland McGrath
2007-12-20 11:53 ` [PATCH -mm 01/43] user_regset header Roland McGrath
2007-12-21 7:06 ` Christoph Hellwig
2007-12-21 8:44 ` Roland McGrath
2007-12-21 10:26 ` Peter Zijlstra
2007-12-21 11:08 ` David Woodhouse
2007-12-20 11:54 ` [PATCH -mm 02/43] elf core dump: notes reorg Roland McGrath
2007-12-20 11:54 ` [PATCH -mm 03/43] elf core dump: notes user_regset Roland McGrath
2007-12-20 11:54 ` [PATCH -mm 04/43] user_regset helpers Roland McGrath
2007-12-20 11:54 ` [PATCH -mm 05/43] compat_binfmt_elf Roland McGrath
2007-12-21 12:55 ` Arnd Bergmann
2007-12-20 11:55 ` [PATCH -mm 06/43] user_regset user-copy helpers Roland McGrath
2007-12-20 11:55 ` [PATCH -mm 07/43] ptrace_request peekdata/pokedata Roland McGrath
2007-12-20 11:55 ` [PATCH -mm 08/43] compat_ptrace_request Roland McGrath
2007-12-20 11:55 ` [PATCH -mm 09/43] compat_sys_ptrace Roland McGrath
2007-12-21 7:11 ` Christoph Hellwig
2007-12-21 8:52 ` Roland McGrath
2007-12-20 11:57 ` [PATCH -mm 10/43] powerpc user_regset fpregs Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` [PATCH -mm 11/43] powerpc user_regset altivec Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` [PATCH -mm 12/43] powerpc user_regset spe Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` [PATCH -mm 13/43] powerpc ptrace special regs Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` [PATCH -mm 14/43] powerpc user_regset gpr Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:57 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 15/43] powerpc user_regset_view Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 16/43] powerpc user_regset compat Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2008-01-07 5:40 ` [PATCH update " Roland McGrath
2008-01-07 5:40 ` Roland McGrath
2008-01-07 5:40 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 17/43] powerpc CORE_DUMP_USE_REGSET Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 18/43] powerpc compat_binfmt_elf Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-21 7:12 ` Christoph Hellwig
2007-12-21 7:12 ` Christoph Hellwig
2007-12-21 8:56 ` Roland McGrath
2007-12-21 8:56 ` Roland McGrath
2007-12-21 17:51 ` Kyle McMartin
2007-12-21 17:51 ` Kyle McMartin
2007-12-21 19:36 ` Arnd Bergmann [this message]
2007-12-21 19:36 ` Arnd Bergmann
2007-12-21 20:00 ` Sam Ravnborg
2007-12-21 20:00 ` Sam Ravnborg
2007-12-20 11:58 ` [PATCH -mm 19/43] powerpc core dump cleanup Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 20/43] powerpc SPE core dump Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 21/43] powerpc ptrace user_regset Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 22/43] powerpc ptrace generic peekdata/pokedata Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 23/43] powerpc compat_ptrace_request Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` [PATCH -mm 24/43] powerpc compat_sys_ptrace Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:58 ` Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 25/43] powerpc ptrace32 user_regset Roland McGrath
2007-12-20 11:59 ` Roland McGrath
2007-12-20 11:59 ` Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 26/43] x86-64 wired cpu_has macros Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 27/43] x86 i387 unify structs Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 28/43] x86 i387 header cleanup Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 29/43] x86 user_regset math_emu Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 30/43] x86: i387 renaming Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 31/43] x86 i387 user_regset Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 32/43] x86 i387 cleanup Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 33/43] x86 TLS desc_struct cleanup Roland McGrath
2007-12-20 11:59 ` [PATCH -mm 34/43] x86 user_regset TLS Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 35/43] x86 user_regset general regs Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 36/43] x86 user_regset_view Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 37/43] x86 CORE_DUMP_USE_REGSET Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 38/43] x86 ptrace user_regset Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 39/43] x86 user_regset cleanup Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 40/43] x86 compat_binfmt_elf Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 41/43] x86 ia32_binfmt removal Roland McGrath
2007-12-20 12:00 ` [PATCH -mm 42/43] x86 core dump TLS Roland McGrath
2007-12-20 12:01 ` [PATCH -mm 43/43] x86 ptrace generic requests Roland McGrath
2007-12-20 13:00 ` [PATCH -mm 00/43] user_regset framework -- arch maintainers take note! Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712212036.29098.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.