From: Andrew Morton <akpm@linux-foundation.org>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] msg.h: Convert m_ts from int to size_t.
Date: Sat, 22 Dec 2007 10:31:37 +0000 [thread overview]
Message-ID: <20071222023137.c8800f6f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071217023600.24944.84644.sendpatchset@thinktank.campus.ltu.se>
On Mon, 17 Dec 2007 03:36:00 +0100 (MET) Richard Knutsson <ricknu-0@student.ltu.se> wrote:
> Convert m_ts ("message text size") from int to size_t.
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Remove some trailing spaces, since we are in the neighborhood.
>
>
> diff --git a/include/linux/msg.h b/include/linux/msg.h
> index 10a3d5a..7a61952 100644
> --- a/include/linux/msg.h
> +++ b/include/linux/msg.h
> @@ -67,8 +67,8 @@ struct msginfo {
> /* one msg_msg structure for each message */
> struct msg_msg {
> struct list_head m_list;
> - long m_type;
> - int m_ts; /* message text size */
> + long m_type;
> + size_t m_ts; /* message text size */
> struct msg_msgseg* next;
> void *security;
> /* the actual message follows immediately */
hm, spose so. But if we're to do this then we'd need to fix qsize and
r_maxsize and various other things. And we'd need to convert msg_bytes to
atomic_size_t, which would prove interesting ;)
So this is at best a partial conversion and the code in there does need
careful checking for the use of appropriate types. Does this patch get us
partway toward the proper solution? Dunno - someone would need to sit down
and work out what the best types are for all those related things.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] msg.h: Convert m_ts from int to size_t.
Date: Sat, 22 Dec 2007 02:31:37 -0800 [thread overview]
Message-ID: <20071222023137.c8800f6f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071217023600.24944.84644.sendpatchset@thinktank.campus.ltu.se>
On Mon, 17 Dec 2007 03:36:00 +0100 (MET) Richard Knutsson <ricknu-0@student.ltu.se> wrote:
> Convert m_ts ("message text size") from int to size_t.
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Remove some trailing spaces, since we are in the neighborhood.
>
>
> diff --git a/include/linux/msg.h b/include/linux/msg.h
> index 10a3d5a..7a61952 100644
> --- a/include/linux/msg.h
> +++ b/include/linux/msg.h
> @@ -67,8 +67,8 @@ struct msginfo {
> /* one msg_msg structure for each message */
> struct msg_msg {
> struct list_head m_list;
> - long m_type;
> - int m_ts; /* message text size */
> + long m_type;
> + size_t m_ts; /* message text size */
> struct msg_msgseg* next;
> void *security;
> /* the actual message follows immediately */
hm, spose so. But if we're to do this then we'd need to fix qsize and
r_maxsize and various other things. And we'd need to convert msg_bytes to
atomic_size_t, which would prove interesting ;)
So this is at best a partial conversion and the code in there does need
careful checking for the use of appropriate types. Does this patch get us
partway toward the proper solution? Dunno - someone would need to sit down
and work out what the best types are for all those related things.
next prev parent reply other threads:[~2007-12-22 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 2:35 [PATCH 1/3] ipc: Convert handmade 'max' to max() Richard Knutsson
2007-12-17 2:35 ` Richard Knutsson
2007-12-17 2:36 ` [PATCH 2/3] msg.h: Convert m_ts from int to size_t Richard Knutsson
2007-12-17 2:36 ` Richard Knutsson
2007-12-22 10:31 ` Andrew Morton [this message]
2007-12-22 10:31 ` Andrew Morton
2007-12-17 2:36 ` [PATCH 3/3] ipc: Convert handmade 'min' to min() Richard Knutsson
2007-12-17 2:36 ` Richard Knutsson
2007-12-22 10:27 ` [PATCH 1/3] ipc: Convert handmade 'max' to max() Andrew Morton
2007-12-22 10:27 ` Andrew Morton
2008-01-04 6:46 ` Richard Knutsson
2008-01-04 6:46 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071222023137.c8800f6f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.