From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] do not use linux/string.h in sha1.c on hosts
Date: Thu, 27 Dec 2007 13:42:56 -0500 [thread overview]
Message-ID: <200712271342.58728.vapier@gentoo.org> (raw)
In-Reply-To: <20071225211414.470F62410D@gemini.denx.de>
On Tuesday 25 December 2007, Wolfgang Denk wrote:
> In message <200712241709.31277.vapier@gentoo.org> you wrote:
> > linux/string.h is not a valid include outside of the kernel, so when
> > compiling sha1.c for the host (for use with the `mkimage` host binary),
> > the include needs to be changed to string.h.
>
> But IIRC mkimage does not use any sha1 code ...
the Makefile claims otherwise ... patch attached to remove sha1.o from mkimage
linking since it isnt actually used.
Signed-Off-By: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/tools/Makefile b/tools/Makefile
index e8e0280..0432253 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -136,7 +136,7 @@ $(obj)img2srec$(SFX): $(obj)img2srec.o
$(CC) $(CFLAGS) $(HOST_LDFLAGS) -o $@ $^
$(STRIP) $@
-$(obj)mkimage$(SFX): $(obj)mkimage.o $(obj)crc32.o $(obj)sha1.o
+$(obj)mkimage$(SFX): $(obj)mkimage.o $(obj)crc32.o
$(CC) $(CFLAGS) $(HOST_LDFLAGS) -o $@ $^
$(STRIP) $@
next prev parent reply other threads:[~2007-12-27 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 22:09 [U-Boot-Users] [patch] do not use linux/string.h in sha1.c on hosts Mike Frysinger
2007-12-24 22:56 ` Mike Frysinger
2007-12-25 21:14 ` Wolfgang Denk
2007-12-27 18:42 ` Mike Frysinger [this message]
2007-12-27 19:28 ` Bartlomiej Sieka
2007-12-27 20:15 ` Wolfgang Denk
2007-12-27 20:36 ` Bartlomiej Sieka
2007-12-28 1:51 ` Josh Boyer
2007-12-27 20:25 ` Mike Frysinger
2008-01-09 20:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712271342.58728.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.