From: Bartlomiej Sieka <tur@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] do not use linux/string.h in sha1.c on hosts
Date: Thu, 27 Dec 2007 21:36:09 +0100 [thread overview]
Message-ID: <47740CB9.1070708@semihalf.com> (raw)
In-Reply-To: <20071227201516.9F2712405E@gemini.denx.de>
Wolfgang Denk wrote:
> In message <4773FCEF.2040507@semihalf.com> you wrote:
>>>> But IIRC mkimage does not use any sha1 code ...
>>> the Makefile claims otherwise ... patch attached to remove sha1.o from mkimage
>>> linking since it isnt actually used.
>
> Indeed the Makefile contained a not needed reference.
>
>> It is likely we'll need sha1 support in mkimage for the new uImage
>> format. Let's wait with this patch until mkimage extension to the new
>> uImage format is settled down.
>
> I'm not so sure. Maybe it's better to clean up now, and deal with the
> new image format requirements when we're at it. Please note that the
> mkimage code has recenty been added to the Linux kernel tree, and
> there the sha1 reference was also removed. I think it makes sense to
> keep both in sync...
I think it makes sense, too.
I am fine with having the clean-up now, and adding sha1 later on when
needed.
Regards,
Barlomiej
next prev parent reply other threads:[~2007-12-27 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 22:09 [U-Boot-Users] [patch] do not use linux/string.h in sha1.c on hosts Mike Frysinger
2007-12-24 22:56 ` Mike Frysinger
2007-12-25 21:14 ` Wolfgang Denk
2007-12-27 18:42 ` Mike Frysinger
2007-12-27 19:28 ` Bartlomiej Sieka
2007-12-27 20:15 ` Wolfgang Denk
2007-12-27 20:36 ` Bartlomiej Sieka [this message]
2007-12-28 1:51 ` Josh Boyer
2007-12-27 20:25 ` Mike Frysinger
2008-01-09 20:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47740CB9.1070708@semihalf.com \
--to=tur@semihalf.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.