* [PATCH net-2.6.25] [IPv4] Remove unused define in include/net/arp.h (HAVE_ARP_CREATE)
@ 2007-12-28 15:20 Rami Rosen
2007-12-31 7:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2007-12-28 15:20 UTC (permalink / raw)
To: davem; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
Hello,
It seems to me that the HAVE_ARP_CREATE (empty) definition, from
include/net/arp.h, can be removed,
since it is not used anywhere in the kernel.
Regards,
Rami Rosen
http://www.linux-foundation.org/en/Net:Network_Overview
Signed-off-by: Rami Rosen <ramirose@gmail.com>
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 267 bytes --]
diff --git a/include/net/arp.h b/include/net/arp.h
index 36482bf..752eb47 100644
--- a/include/net/arp.h
+++ b/include/net/arp.h
@@ -5,7 +5,6 @@
#include <linux/if_arp.h>
#include <net/neighbour.h>
-#define HAVE_ARP_CREATE
extern struct neigh_table arp_tbl;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6.25] [IPv4] Remove unused define in include/net/arp.h (HAVE_ARP_CREATE)
2007-12-28 15:20 [PATCH net-2.6.25] [IPv4] Remove unused define in include/net/arp.h (HAVE_ARP_CREATE) Rami Rosen
@ 2007-12-31 7:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-12-31 7:23 UTC (permalink / raw)
To: ramirose; +Cc: netdev
From: "Rami Rosen" <ramirose@gmail.com>
Date: Fri, 28 Dec 2007 17:20:34 +0200
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
This was added long ago by some bonding driver infrastructure changes
so that code could check whether the arp_create() helper function
existed in the kernel.
But it is totally unused now and yes it should be removed.
Patch applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-31 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-28 15:20 [PATCH net-2.6.25] [IPv4] Remove unused define in include/net/arp.h (HAVE_ARP_CREATE) Rami Rosen
2007-12-31 7:23 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.