From: Ingo Molnar <mingo@elte.hu>
To: Julia Lawall <julia@diku.dk>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq,
Date: Sun, 30 Dec 2007 15:41:27 +0000 [thread overview]
Message-ID: <20071230154127.GA10444@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0712301554430.8187@ask.diku.dk>
* Julia Lawall <julia@diku.dk> wrote:
> > your x86 patches (#7, #8 and #9) do not include any *_eq()
> > comparisons and they all seem to be correct. So picked those three
> > up into x86.git - let me know if there's any breakage in them that i
> > missed.
>
> Only #7 is ok. The other two have #include <jiffies.h> in the wrong
> place. I will send new versions of #8 and #9 shortly.
hm, #include file order in a .c file should normally not matter - why
are they in the wrong place?
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Julia Lawall <julia@diku.dk>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
Date: Sun, 30 Dec 2007 16:41:27 +0100 [thread overview]
Message-ID: <20071230154127.GA10444@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0712301554430.8187@ask.diku.dk>
* Julia Lawall <julia@diku.dk> wrote:
> > your x86 patches (#7, #8 and #9) do not include any *_eq()
> > comparisons and they all seem to be correct. So picked those three
> > up into x86.git - let me know if there's any breakage in them that i
> > missed.
>
> Only #7 is ok. The other two have #include <jiffies.h> in the wrong
> place. I will send new versions of #8 and #9 shortly.
hm, #include file order in a .c file should normally not matter - why
are they in the wrong place?
Ingo
next prev parent reply other threads:[~2007-12-30 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 14:23 [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Julia Lawall
2007-12-24 14:23 ` Julia Lawall
2007-12-24 15:31 ` Andi Kleen
2007-12-24 15:31 ` Andi Kleen
2007-12-24 15:58 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, Julia Lawall
2007-12-24 15:58 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Julia Lawall
2007-12-30 13:33 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, Ingo Molnar
2007-12-30 13:33 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Ingo Molnar
2007-12-30 14:55 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, Julia Lawall
2007-12-30 14:55 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Julia Lawall
2007-12-30 15:41 ` Ingo Molnar [this message]
2007-12-30 15:41 ` Ingo Molnar
2007-12-30 15:51 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, Julia Lawall
2007-12-30 15:51 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Julia Lawall
2007-12-30 16:04 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, Ingo Molnar
2007-12-30 16:04 ` [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230154127.GA10444@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.