From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to
Date: Sun, 30 Dec 2007 21:49:34 +0000 [thread overview]
Message-ID: <20071230214857.GA14177@joi> (raw)
In-Reply-To: <20071230191825.GA6447@infradead.org>
On Sun, Dec 30, 2007 at 07:18:25PM +0000, Christoph Hellwig wrote:
> On Sun, Dec 30, 2007 at 08:06:34PM +0100, Marcin Slusarz wrote:
> > There are many places where these functions would be useful.
> > (just look at: grep -r 'cpu_to_[ble12346]*([ble12346]*_to_cpu.*[-+]' linux-src/)
> > What do you think?
> >
> > ps: this patch depends on http://lkml.org/lkml/2007/12/25/35
> > --
> >
> > add inline functions which add native byte order variable to
> > little/big endian variable to core header and as an example
> > convert ext3 to use them
>
> Various places already have this as be*_add / le*_add, so it might be
> more useful to keep those names already in use.
I found it in XFS only. Did I miss something?
be32_add is shorter than be32_add_cpu but I think it's not clear
whether second parameter is in native byte order or not.
Marcin
WARNING: multiple messages have this Message-ID (diff)
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core
Date: Sun, 30 Dec 2007 22:49:34 +0100 [thread overview]
Message-ID: <20071230214857.GA14177@joi> (raw)
In-Reply-To: <20071230191825.GA6447@infradead.org>
On Sun, Dec 30, 2007 at 07:18:25PM +0000, Christoph Hellwig wrote:
> On Sun, Dec 30, 2007 at 08:06:34PM +0100, Marcin Slusarz wrote:
> > There are many places where these functions would be useful.
> > (just look at: grep -r 'cpu_to_[ble12346]*([ble12346]*_to_cpu.*[-+]' linux-src/)
> > What do you think?
> >
> > ps: this patch depends on http://lkml.org/lkml/2007/12/25/35
> > --
> >
> > add inline functions which add native byte order variable to
> > little/big endian variable to core header and as an example
> > convert ext3 to use them
>
> Various places already have this as be*_add / le*_add, so it might be
> more useful to keep those names already in use.
I found it in XFS only. Did I miss something?
be32_add is shorter than be32_add_cpu but I think it's not clear
whether second parameter is in native byte order or not.
Marcin
next prev parent reply other threads:[~2007-12-30 21:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 19:06 [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Marcin Slusarz
2007-12-30 19:06 ` Marcin Slusarz
2007-12-30 19:18 ` [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to Christoph Hellwig
2007-12-30 19:18 ` [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Christoph Hellwig
2007-12-30 21:49 ` Marcin Slusarz [this message]
2007-12-30 21:49 ` Marcin Slusarz
2007-12-31 9:17 ` [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to Christoph Hellwig
2007-12-31 9:17 ` [Ocfs2-devel] [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Christoph Hellwig
2007-12-31 9:17 ` Christoph Hellwig
2007-12-31 11:43 ` [Ocfs2-devel] " Mark Fasheh
2007-12-31 19:41 ` Mark Fasheh
2007-12-31 19:41 ` [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to Mark Fasheh
2007-12-31 11:39 ` [Ocfs2-devel] Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Mark Fasheh
2007-12-31 19:38 ` Mark Fasheh
2007-12-31 19:38 ` [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to Mark Fasheh
2007-12-31 20:04 ` [Ocfs2-devel] [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Marcin Slusarz
2007-12-31 20:05 ` Marcin Slusarz
2007-12-31 20:05 ` [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230214857.GA14177@joi \
--to=marcin.slusarz@gmail.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.