[Fwd: [Xen-users] two serial port in HVM DomU patch]

[Fwd: [Xen-users] two serial port in HVM DomU patch]

[Stephan Seitz]

[-- Attachment #1.1.1: Type: text/plain, Size: 499 bytes --]

Hi,

attached is a patch posted at xen-users from Mishell Baranov for qemu-dm to support two serial lines.

I think this is a feature that could be implemented in the unstable and testing branches.

Regards,


-- 
Stephan Seitz
Senior System Administrator

*netz-haut* e.K.
multimediale kommunikation

zweierweg 22
97074 würzburg

fon: +49 931 2876247
fax: +49 931 2876248

web: www.netz-haut.de <http://www.netz-haut.de/>

registriergericht: amtsgericht würzburg, hra 5054

[-- Attachment #1.1.2: [Xen-users] two serial port in HVM DomU patch.eml --]
[-- Type: message/rfc822, Size: 8077 bytes --]

[-- Attachment #1.1.2.1.1: Type: text/plain, Size: 153 bytes --]

hi
Litle hack to allow 2 serial port's in HVM.
in config set seriala=/dev/ttyS0 serialb=/dev/ttyS1
it's work for me.
some body else was intresting that.

[-- Attachment #1.1.2.1.2: serial.patch --]
[-- Type: text/x-diff, Size: 4062 bytes --]

diff -ur xen-3.1-3.1.0/tools/ioemu/vl.c xen-3.1-3.1.0-my/tools/ioemu/vl.c
--- xen-3.1-3.1.0/tools/ioemu/vl.c	2007-05-18 20:45:21.000000000 +0600
+++ xen-3.1-3.1.0-my/tools/ioemu/vl.c	2007-12-30 14:45:13.000000000 +0500
@@ -5515,7 +5515,8 @@
     QEMU_OPTION_std_vga,
     QEMU_OPTION_monitor,
     QEMU_OPTION_domainname,
-    QEMU_OPTION_serial,
+    QEMU_OPTION_seriala,
+    QEMU_OPTION_serialb,
     QEMU_OPTION_parallel,
     QEMU_OPTION_loadvm,
     QEMU_OPTION_full_screen,
@@ -5603,7 +5604,8 @@
     { "std-vga", 0, QEMU_OPTION_std_vga },
     { "monitor", 1, QEMU_OPTION_monitor },
     { "domain-name", 1, QEMU_OPTION_domainname },
-    { "serial", 1, QEMU_OPTION_serial },
+    { "seriala", 1, QEMU_OPTION_seriala },
+    { "serialb", 1, QEMU_OPTION_serialb },
     { "parallel", 1, QEMU_OPTION_parallel },
     { "loadvm", HAS_ARG, QEMU_OPTION_loadvm },
     { "full-screen", 0, QEMU_OPTION_full_screen },
@@ -6465,7 +6467,8 @@
             case QEMU_OPTION_monitor:
                 pstrcpy(monitor_device, sizeof(monitor_device), optarg);
                 break;
-            case QEMU_OPTION_serial:
+            case QEMU_OPTION_seriala:
+            case QEMU_OPTION_serialb:
                 if (serial_device_index >= MAX_SERIAL_PORTS) {
                     fprintf(stderr, "qemu: too many serial ports\n");
                     exit(1);
diff -ur xen-3.1-3.1.0/tools/python/xen/xend/image.py xen-3.1-3.1.0-my/tools/python/xen/xend/image.py
--- xen-3.1-3.1.0/tools/python/xen/xend/image.py	2007-05-18 20:45:21.000000000 +0600
+++ xen-3.1-3.1.0-my/tools/python/xen/xend/image.py	2007-12-30 19:24:14.000000000 +0500
@@ -299,7 +299,7 @@
     # xm config file
     def parseDeviceModelArgs(self, vmConfig):
         dmargs = [ 'boot', 'fda', 'fdb', 'soundhw',
-                   'localtime', 'serial', 'stdvga', 'isa',
+                   'localtime', 'seriala', 'serialb', 'stdvga', 'isa',
                    'acpi', 'usb', 'usbdevice', 'keymap' ]
         
         ret = ['-vcpus', str(self.vm.getVCpuCount())]
diff -ur xen-3.1-3.1.0/tools/python/xen/xend/XendConfig.py xen-3.1-3.1.0-my/tools/python/xen/xend/XendConfig.py
--- xen-3.1-3.1.0/tools/python/xen/xend/XendConfig.py	2007-05-18 20:45:21.000000000 +0600
+++ xen-3.1-3.1.0-my/tools/python/xen/xend/XendConfig.py	2007-12-30 19:25:04.000000000 +0500
@@ -119,7 +119,7 @@
 # Platform configuration keys.
 XENAPI_PLATFORM_CFG = [ 'acpi', 'apic', 'boot', 'device_model', 'display', 
                         'fda', 'fdb', 'keymap', 'isa', 'localtime', 'monitor', 
-                        'nographic', 'pae', 'rtc_timeoffset', 'serial', 'sdl',
+                        'nographic', 'pae', 'rtc_timeoffset', 'seriala', 'serialb', 'sdl',
                         'soundhw','stdvga', 'usb', 'usbdevice', 'vnc',
                         'vncconsole', 'vncdisplay', 'vnclisten',
                         'vncpasswd', 'vncunused', 'xauthority']
diff -ur xen-3.1-3.1.0/tools/python/xen/xm/create.py xen-3.1-3.1.0-my/tools/python/xen/xm/create.py
--- xen-3.1-3.1.0/tools/python/xen/xm/create.py	2007-05-18 20:45:21.000000000 +0600
+++ xen-3.1-3.1.0-my/tools/python/xen/xm/create.py	2007-12-30 19:25:57.000000000 +0500
@@ -417,7 +417,11 @@
           fn=set_value, default='',
           use="Path to fdb")
 
-gopts.var('serial', val='FILE',
+gopts.var('seriala', val='FILE',
+          fn=set_value, default='',
+          use="Path to serial or pty or vc")
+
+gopts.var('serialb', val='FILE',
           fn=set_value, default='',
           use="Path to serial or pty or vc")
 
@@ -723,7 +727,7 @@
     """Create the config for HVM devices.
     """
     args = [ 'device_model', 'pae', 'vcpus', 'boot', 'fda', 'fdb',
-             'localtime', 'serial', 'stdvga', 'isa', 'nographic', 'soundhw',
+             'localtime', 'seriala', 'serialb', 'stdvga', 'isa', 'nographic', 'soundhw',
              'vnc', 'vncdisplay', 'vncunused', 'vncconsole', 'vnclisten',
              'sdl', 'display', 'xauthority', 'rtc_timeoffset', 'monitor',
              'acpi', 'apic', 'usb', 'usbdevice', 'keymap' ]

[-- Attachment #1.1.2.1.3: Type: text/plain, Size: 137 bytes --]

_______________________________________________
Xen-users mailing list
Xen-users@lists.xensource.com
http://lists.xensource.com/xen-users

[-- Attachment #1.1.3: s_seitz.vcf --]
[-- Type: text/x-vcard, Size: 335 bytes --]

begin:vcard
fn:Stephan Seitz
n:Seitz;Stephan
org:netz-haut e.K.
adr:;;Zweierweg 22;Wuerzburg;Bayern;97074;Deutschland
email;internet:s.seitz@netz-haut.de
title:Senior System Administrator
tel;work:+49-931-287-6247
tel;fax:+49-931-287-6248
x-mozilla-html:FALSE
url:http://www.schwarz-mode.de/files/
version:2.1
end:vcard


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: [Fwd: [Xen-users] two serial port in HVM DomU patch]

[James Harper]

How much more work would it take to support an arbitrary number of serial ports?

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-
> bounces@lists.xensource.com] On Behalf Of Stephan Seitz
> Sent: Monday, 31 December 2007 23:13
> To: XEN Devel - listmembers
> Subject: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
> 
> Hi,
> 
> attached is a patch posted at xen-users from Mishell Baranov for qemu-dm
> to support two serial lines.
> 
> I think this is a feature that could be implemented in the unstable and
> testing branches.
> 
> Regards,
> 
> 
> --
> Stephan Seitz
> Senior System Administrator
> 
> *netz-haut* e.K.
> multimediale kommunikation
> 
> zweierweg 22
> 97074 würzburg
> 
> fon: +49 931 2876247
> fax: +49 931 2876248
> 
> web: www.netz-haut.de <http://www.netz-haut.de/>
> 
> registriergericht: amtsgericht würzburg, hra 5054

Re: [Fwd: [Xen-users] two serial port in HVM DomU patch]

[Samuel Thibault]

Hi,

Stephan Seitz, le Mon 31 Dec 2007 13:13:06 +0100, a écrit :
> @@ -5603,7 +5604,8 @@
> -    { "serial", 1, QEMU_OPTION_serial },
> +    { "seriala", 1, QEMU_OPTION_seriala },
> +    { "serialb", 1, QEMU_OPTION_serialb },

There is no real need to do this: qemu can handle several -serial
options fine.

> diff -ur xen-3.1-3.1.0/tools/python/xen/xm/create.py xen-3.1-3.1.0-my/tools/python/xen/xm/create.py
> --- xen-3.1-3.1.0/tools/python/xen/xm/create.py	2007-05-18 20:45:21.000000000 +0600
> +++ xen-3.1-3.1.0-my/tools/python/xen/xm/create.py	2007-12-30 19:25:57.000000000 +0500
> -gopts.var('serial', val='FILE',

And that could be a list of serial/pty/vc/...

Samuel

Re: [Fwd: [Xen-users] two serial port in HVM DomU patch]

[Keir Fraser]

Ah, this is a nice way that continues to support the existing domain config
format. I'd still also like a dm_args config option too though! Really many
of the HVM-specific config options could be deprecated and moved over to a
single dm_args config field.

 -- Keir

On 31/12/07 12:41, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wrote:

> Hi,
> 
> Stephan Seitz, le Mon 31 Dec 2007 13:13:06 +0100, a écrit :
>> @@ -5603,7 +5604,8 @@
>> -    { "serial", 1, QEMU_OPTION_serial },
>> +    { "seriala", 1, QEMU_OPTION_seriala },
>> +    { "serialb", 1, QEMU_OPTION_serialb },
> 
> There is no real need to do this: qemu can handle several -serial
> options fine.
> 
>> diff -ur xen-3.1-3.1.0/tools/python/xen/xm/create.py
>> xen-3.1-3.1.0-my/tools/python/xen/xm/create.py
>> --- xen-3.1-3.1.0/tools/python/xen/xm/create.py 2007-05-18 20:45:21.000000000
>> +0600
>> +++ xen-3.1-3.1.0-my/tools/python/xen/xm/create.py 2007-12-30
>> 19:25:57.000000000 +0500
>> -gopts.var('serial', val='FILE',
> 
> And that could be a list of serial/pty/vc/...
> 
> Samuel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: [Fwd: [Xen-users] two serial port in HVM DomU patch]

[Daniel P. Berrange]

On Sun, Jan 06, 2008 at 10:46:20PM +0000, Keir Fraser wrote:
> Ah, this is a nice way that continues to support the existing domain config
> format. I'd still also like a dm_args config option too though! Really many
> of the HVM-specific config options could be deprecated and moved over to a
> single dm_args config field.

No no no, please no. The current scheme is good because there are clear 
key,value pairs for each individual configuration option. A generic blob
of dm_args will be a huge PITA to deal with, making a mockery of the
attempt at clearly modelling guest config params in XenAPI, as well as the 
legacy config formats. It will also increase the divergance in the way
HVM guests are configured vs paravirt guests if we start to shove all the
HVM args into 'dm_args' rather than representing them in a way which works
well for both HVM and PV domains.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Re: [Fwd: [Xen-users] two serial port in HVM DomU patch]

[Keir Fraser]

I'd advocate a dm_args domain config option, which would be a string of qemu
command-line arguments which would be dumbly passed straight through to
qemu-dm without any further processing by xend.

Then you could just do 'dm_args = "serial=/dev/ttyS0 serial=/dev/ttyS1"' and
not need any changes to qemu source code at all. And this would also let you
get at any other underlying features of qemu too. Much nicer.

This would certainly be a good thing post 3.2.0 and 3.1.3.

 -- Keir

On 31/12/07 12:13, "Stephan Seitz" <s.seitz@netz-haut.de> wrote:

> Hi,
> 
> attached is a patch posted at xen-users from Mishell Baranov for qemu-dm to
> support two serial lines.
> 
> I think this is a feature that could be implemented in the unstable and
> testing branches.
> 
> Regards,
> 

Re: [Fwd: [Xen-users] two serial port in HVM DomU patch]

[Daniel P. Berrange]

On Sun, Jan 06, 2008 at 10:43:23PM +0000, Keir Fraser wrote:
> I'd advocate a dm_args domain config option, which would be a string of qemu
> command-line arguments which would be dumbly passed straight through to
> qemu-dm without any further processing by xend.
>
> Then you could just do 'dm_args = "serial=/dev/ttyS0 serial=/dev/ttyS1"' and
> not need any changes to qemu source code at all. And this would also let you
> get at any other underlying features of qemu too. Much nicer.

I think that's a bad idea as any info in this generic 'dm_args' is now lost
to the formal API data model. eg If a management app wants to talk to XenD
and determine how / if the serial port is configured, it now has to look
at both the formally specified 'serial' param, and also parse the command
line args in 'dm_args'.  Sure it means we have to write less code in XenD,
but it means that all users talking to XenD have much more work todo. I
don't really see that as a net win.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|