From: Paul Mundt <lethal@linux-sh.org>
To: Andrew Murray <amurray@mpc-data.co.uk>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: sh7712 clock support
Date: Mon, 31 Dec 2007 16:49:59 +0000 [thread overview]
Message-ID: <20071231164959.GA23319@linux-sh.org> (raw)
In-Reply-To: <0C997DD87CC88A4F86C897F52650B52B820E8F@MOLSON.mpc-data.co.uk>
On Mon, Dec 31, 2007 at 04:32:25PM -0000, Andrew Murray wrote:
> +static void bus_clk_init(struct clk *clk)
> +{
> + clk->rate = CONFIG_SH_PCLK_FREQ;
> +}
> +
> +static struct clk_ops sh7712_bus_clk_ops = {
> + .init = bus_clk_init,
> +};
> +
This shouldn't be necessary, the bus clk already references the master
clk as its parent, and inherits the rate from there. If you have no
recalc work to do, then you should be able to just leave this out
altogether. If you actually need this dummy init, then something is
broken with the upper layer, which we should fix ;-)
Patch looks fine otherwise. Tidy this up and I'll apply it.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Andrew Murray <amurray@mpc-data.co.uk>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: sh7712 clock support
Date: Tue, 1 Jan 2008 01:49:59 +0900 [thread overview]
Message-ID: <20071231164959.GA23319@linux-sh.org> (raw)
In-Reply-To: <0C997DD87CC88A4F86C897F52650B52B820E8F@MOLSON.mpc-data.co.uk>
On Mon, Dec 31, 2007 at 04:32:25PM -0000, Andrew Murray wrote:
> +static void bus_clk_init(struct clk *clk)
> +{
> + clk->rate = CONFIG_SH_PCLK_FREQ;
> +}
> +
> +static struct clk_ops sh7712_bus_clk_ops = {
> + .init = bus_clk_init,
> +};
> +
This shouldn't be necessary, the bus clk already references the master
clk as its parent, and inherits the rate from there. If you have no
recalc work to do, then you should be able to just leave this out
altogether. If you actually need this dummy init, then something is
broken with the upper layer, which we should fix ;-)
Patch looks fine otherwise. Tidy this up and I'll apply it.
next prev parent reply other threads:[~2007-12-31 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 16:32 [PATCH] sh: sh7712 clock support Andrew Murray
2007-12-31 16:32 ` Andrew Murray
2007-12-31 16:49 ` Paul Mundt [this message]
2007-12-31 16:49 ` Paul Mundt
2007-12-31 18:20 ` Andrew Murray
2007-12-31 18:20 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071231164959.GA23319@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=amurray@mpc-data.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.