All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Harper <ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Filip Navara <filip.navara-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [Qemu-devel] [PATCH 2 of 3] Optionally link against libuuid if present
Date: Thu, 3 Jan 2008 13:55:42 -0600	[thread overview]
Message-ID: <20080103195542.GT23913@us.ibm.com> (raw)
In-Reply-To: <5b31733c0712111319s2109e935o19c9d51d091a4056-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

* Filip Navara <filip.navara-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [2007-12-11 15:29]:
> Hi Ryan & others,
> 
> now I have been holding a SMBIOS patch on my hard disk for way to long it
> seems. I used a different approach from yours, so I decided to publish it
> for review or further ideas. What I did was to modify the bochs bios to
> produce the SMBIOS tables and I get the UUID using VMware backdoor port from
> the virtual machine.
> 
> Attached are just the changed files, creating a patch will take a while
> because it's against VERY OLD version of the sources.

Filip,

Thanks for posting this.  I agree with Fabrice that doing the SMBIOS
tables in rombios is a better approach.  The rombio32.c file you
included didn't look that old to me; it has a CVS release tag of:
'rombios32.c,v 1.11 2007/08/03 13:56:13'  

AFAICT, it looks like a straight-forward SMBIOS implementation.  The
only thing worth adding to yours is the BIOS release date string in the
type 0 table.  Setting this date to something newer than typical
CONFIG_ACPI_BLACKLIST_YEAR value (2000 in Gutsy's kernels) lets the
kernel enable ACPI features (like power-off).

Any idea on when you might have a patch that I can test?

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

WARNING: multiple messages have this Message-ID (diff)
From: Ryan Harper <ryanh@us.ibm.com>
To: Filip Navara <filip.navara@gmail.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2 of 3] Optionally link against libuuid if present
Date: Thu, 3 Jan 2008 13:55:42 -0600	[thread overview]
Message-ID: <20080103195542.GT23913@us.ibm.com> (raw)
In-Reply-To: <5b31733c0712111319s2109e935o19c9d51d091a4056@mail.gmail.com>

* Filip Navara <filip.navara@gmail.com> [2007-12-11 15:29]:
> Hi Ryan & others,
> 
> now I have been holding a SMBIOS patch on my hard disk for way to long it
> seems. I used a different approach from yours, so I decided to publish it
> for review or further ideas. What I did was to modify the bochs bios to
> produce the SMBIOS tables and I get the UUID using VMware backdoor port from
> the virtual machine.
> 
> Attached are just the changed files, creating a patch will take a while
> because it's against VERY OLD version of the sources.

Filip,

Thanks for posting this.  I agree with Fabrice that doing the SMBIOS
tables in rombios is a better approach.  The rombio32.c file you
included didn't look that old to me; it has a CVS release tag of:
'rombios32.c,v 1.11 2007/08/03 13:56:13'  

AFAICT, it looks like a straight-forward SMBIOS implementation.  The
only thing worth adding to yours is the BIOS release date string in the
type 0 table.  Setting this date to something newer than typical
CONFIG_ACPI_BLACKLIST_YEAR value (2000 in Gutsy's kernels) lets the
kernel enable ACPI features (like power-off).

Any idea on when you might have a patch that I can test?

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com

  parent reply	other threads:[~2008-01-03 19:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11 20:08 [PATCH 0 of 3] Add SMBIOS/DMI table generation to PC machine Ryan Harper
2007-12-11 20:08 ` [Qemu-devel] " Ryan Harper
     [not found] ` <patchbomb.1197403730-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-12-11 20:08   ` [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines Ryan Harper
2007-12-11 20:08     ` [Qemu-devel] " Ryan Harper
2007-12-11 20:08   ` [PATCH 2 of 3] Optionally link against libuuid if present Ryan Harper
2007-12-11 20:08     ` [Qemu-devel] " Ryan Harper
2007-12-11 21:19     ` Filip Navara
2007-12-11 21:19       ` [Qemu-devel] " Filip Navara
2007-12-12 22:51       ` Fabrice Bellard
     [not found]       ` <5b31733c0712111319s2109e935o19c9d51d091a4056-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-03 19:55         ` Ryan Harper [this message]
2008-01-03 19:55           ` Ryan Harper
     [not found]           ` <20080103195542.GT23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-20 13:17             ` Filip Navara
2008-01-20 13:17               ` Filip Navara
2008-01-20 14:25               ` Paul Brook
2008-01-20 15:26                 ` Filip Navara
     [not found]               ` <5b31733c0801200517m166d35aencd4a4233d5ac09cc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-20 16:20                 ` Alexander Graf
2008-01-20 16:20                   ` [kvm-devel] " Alexander Graf
     [not found]                   ` <CA9EF1A7-B046-4EF0-8DD2-0DB33F3F2042-r27SGEef+tmzQB+pC5nmwQ@public.gmane.org>
2008-01-20 16:37                     ` Filip Navara
2008-01-20 16:37                       ` [kvm-devel] " Filip Navara
     [not found]                       ` <5b31733c0801200837u2425876dyd2b05a565b7eb023-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-20 16:53                         ` Alexander Graf
2008-01-20 16:53                           ` [kvm-devel] " Alexander Graf
     [not found]                           ` <EB2C2C51-0654-4872-98EC-F8EB4497CCAA-r27SGEef+tmzQB+pC5nmwQ@public.gmane.org>
2008-01-20 17:01                             ` Filip Navara
2008-01-20 17:01                               ` [kvm-devel] " Filip Navara
2007-12-11 21:21     ` Filip Navara
2007-12-11 21:21       ` [Qemu-devel] " Filip Navara
2007-12-11 20:08   ` [PATCH 3 of 3] Add -uuid command line flag Ryan Harper
2007-12-11 20:08     ` [Qemu-devel] " Ryan Harper
  -- strict thread matches above, loose matches on Subject: below --
2007-12-07 20:45 [Qemu-devel] [PATCH 0 of 3] Add SMBIOS/DMI table generation to PC machine Ryan Harper
2007-12-07 20:45 ` [Qemu-devel] [PATCH 2 of 3] Optionally link against libuuid if present Ryan Harper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103195542.GT23913@us.ibm.com \
    --to=ryanh-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=filip.navara-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.