[PATCH] skip `.' and `..' directories in TAB completion

[PATCH] skip `.' and `..' directories in TAB completion

[Robert Millan]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]


This patch skips . and .. directories in tab completion.  They're basicaly
useless to the user, and this mimics bash completion behaviour.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

[-- Attachment #2: completion.diff --]
[-- Type: text/x-diff, Size: 584 bytes --]


	* normal/completion.c (iterate_dir): Skip `.' and `..' directories.

diff -urp -x CVS grub2/normal/completion.c grub2.completion/normal/completion.c
--- grub2/normal/completion.c	2007-09-03 22:28:24.000000000 +0200
+++ grub2.completion/normal/completion.c	2008-01-04 13:11:49.000000000 +0100
@@ -138,7 +138,7 @@ iterate_dir (const char *filename, int d
       if (add_completion (filename, prefix, GRUB_COMPLETION_TYPE_FILE))
 	return 1;
     }
-  else
+  else if (grub_strcmp (filename, ".") && grub_strcmp (filename, ".."))
     {
       char fname[grub_strlen (filename) + 2];
 

Re: [PATCH] skip `.' and `..' directories in TAB completion

[Yoshinori K. Okuji]

On Friday 04 January 2008 13:14, Robert Millan wrote:
> This patch skips . and .. directories in tab completion.  They're basicaly
> useless to the user, and this mimics bash completion behaviour.

Okay for me.

Thanks,
Okuji

Re: [PATCH] skip `.' and `..' directories in TAB completion

[Robert Millan]

On Sat, Jan 05, 2008 at 02:35:35AM +0100, Yoshinori K. Okuji wrote:
> On Friday 04 January 2008 13:14, Robert Millan wrote:
> > This patch skips . and .. directories in tab completion.  They're basicaly
> > useless to the user, and this mimics bash completion behaviour.
> 
> Okay for me.

Committed.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)