Re: grub-pc: installation failure under linux + udev

Re: grub-pc: installation failure under linux + udev

[Robert Millan]

On Thu, Jan 03, 2008 at 11:14:23PM +0100, Pascal A. Dupuis wrote:
> Hello,
> 
> this is a copy of debian bug 450709
> (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=450709) at
> debian maintainer's (Robert Millan <rmh at aybabtu dot com>) request: 

Thanks Pascal.

> But ... util/biosdisk.c has another issue with detecting udev. The 
> routine has_devfs searchs for /dev/.devfsd, which cames from deprecated 
> devfs. Enclosed is a synthetic patch, I compiled and ran it fine on my 
> machine. Could you check ?

The off-by-5 bug is already fixed in CVS.  As for the devfs part, I think
I figured out what you're doing.  You setup udev to emulate devfs-style
devices, right?

I think the right fix for this is not to check for /dev/.udev, but rather
just probe for devfs-style devices unconditionally.

As it happens there are other ways in which one could have this layout,
including other /dev implementations such as userdevfs.

What does everyone else think?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Re: grub-pc: installation failure under linux + udev

[Yoshinori K. Okuji]

On Friday 04 January 2008 00:54, Robert Millan wrote:
> On Thu, Jan 03, 2008 at 11:14:23PM +0100, Pascal A. Dupuis wrote:
> > Hello,
> >
> > this is a copy of debian bug 450709
> > (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=450709) at
> > debian maintainer's (Robert Millan <rmh at aybabtu dot com>) request:
>
> Thanks Pascal.
>
> > But ... util/biosdisk.c has another issue with detecting udev. The
> > routine has_devfs searchs for /dev/.devfsd, which cames from deprecated
> > devfs. Enclosed is a synthetic patch, I compiled and ran it fine on my
> > machine. Could you check ?
>
> The off-by-5 bug is already fixed in CVS.  As for the devfs part, I think
> I figured out what you're doing.  You setup udev to emulate devfs-style
> devices, right?
>
> I think the right fix for this is not to check for /dev/.udev, but rather
> just probe for devfs-style devices unconditionally.
>
> As it happens there are other ways in which one could have this layout,
> including other /dev implementations such as userdevfs.
>
> What does everyone else think?

As long as it works fine, no problem. :)

Okuji

Re: grub-pc: installation failure under linux + udev

[Robert Millan]

On Sat, Jan 05, 2008 at 02:31:51AM +0100, Yoshinori K. Okuji wrote:
> On Friday 04 January 2008 00:54, Robert Millan wrote:
> > On Thu, Jan 03, 2008 at 11:14:23PM +0100, Pascal A. Dupuis wrote:
> > > Hello,
> > >
> > > this is a copy of debian bug 450709
> > > (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=450709) at
> > > debian maintainer's (Robert Millan <rmh at aybabtu dot com>) request:
> >
> > Thanks Pascal.
> >
> > > But ... util/biosdisk.c has another issue with detecting udev. The
> > > routine has_devfs searchs for /dev/.devfsd, which cames from deprecated
> > > devfs. Enclosed is a synthetic patch, I compiled and ran it fine on my
> > > machine. Could you check ?
> >
> > The off-by-5 bug is already fixed in CVS.  As for the devfs part, I think
> > I figured out what you're doing.  You setup udev to emulate devfs-style
> > devices, right?
> >
> > I think the right fix for this is not to check for /dev/.udev, but rather
> > just probe for devfs-style devices unconditionally.
> >
> > As it happens there are other ways in which one could have this layout,
> > including other /dev implementations such as userdevfs.
> >
> > What does everyone else think?
> 
> As long as it works fine, no problem. :)

Ok, fixed.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Re: grub-pc: installation failure under linux + udev

[Robert Millan]

On Mon, Jan 07, 2008 at 06:39:59PM +0100, Pascal A. Dupuis wrote:
> On Sat, Jan 05, 2008 at 01:01:39PM +0100, Robert Millan wrote:
> > > >
> > > > What does everyone else think?
> > > 
> > > As long as it works fine, no problem. :)
> > 
> > Ok, fixed.
> >
> 
> I guess was I sent was the simplest test. Otherwise you should  have
> to start other processes, like:
> ps ax| grep udev
> udevinfo --query=all --name="dev of the root drive"
> 
> OTOH, you could also apply the Open Source Motto, 'release early, release 
> often', so that others may further optimise my patch, if required.

Actually, what I did was not checking for devfs at all, and probe for
devfs-style devices unconditionally.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)