From: Al Boldi <a1426z@gawab.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Sam Ravnborg <sam@ravnborg.org>, Adrian Bunk <bunk@kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support
Date: Sun, 6 Jan 2008 20:07:31 +0300 [thread overview]
Message-ID: <200801062007.31516.a1426z@gawab.com> (raw)
In-Reply-To: <4780E814.4050405@s5r6.in-berlin.de>
Stefan Richter wrote:
> Al Boldi wrote:
> > Sam Ravnborg wrote:
> >> And that requires you to use select only to select symbols with
> >> no dependencies.
> >>
> >> In this case we do not know if BLOCK is enabled or not.
> >
> > Good point! How about we solve it like this:
> >
> > menuconfig USB_STORAGE
> > tristate "USB Mass Storage support"
> > - depends on USB && SCSI
> > + depends on USB && BLOCK
> > + select SCSI
>
> Still wrong. SCSI also needs HAS_DMA and SCSI_DMA.
I don't think so. SCSI selects SCSI_DMA, it doesn't depend on it. So it's
safe to select SCSI here, as libata does it the same way.
Thanks!
--
Al
next prev parent reply other threads:[~2008-01-06 17:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 15:41 [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support Al Boldi
2008-01-05 18:42 ` David Brownell
2008-01-05 19:30 ` Randy Dunlap
2008-01-05 21:03 ` Adrian Bunk
2008-01-05 21:09 ` Sam Ravnborg
2008-01-05 23:22 ` Randy Dunlap
2008-01-05 23:45 ` Adrian Bunk
2008-01-06 0:35 ` Stefan Richter
2008-01-06 0:58 ` Adrian Bunk
2008-01-06 11:29 ` Stefan Richter
2008-01-06 11:59 ` Adrian Bunk
2008-01-06 12:32 ` Stefan Richter
2008-01-06 12:58 ` Adrian Bunk
2008-01-06 13:23 ` Stefan Richter
2008-01-06 12:18 ` Stefan Richter
2008-01-06 12:37 ` Adrian Bunk
2008-01-06 13:13 ` Stefan Richter
2008-01-06 13:38 ` Adrian Bunk
2008-01-06 13:55 ` Sam Ravnborg
2008-01-06 13:57 ` Stefan Richter
2008-01-06 14:45 ` david
2008-01-06 13:41 ` Stefan Richter
2008-01-06 15:05 ` david
2008-01-06 14:08 ` Stefan Richter
2008-01-06 17:11 ` Alan Stern
2008-01-06 18:07 ` Stefan Richter
2008-01-06 1:01 ` Randy Dunlap
2008-01-06 11:54 ` Stefan Richter
2008-01-06 12:05 ` Adrian Bunk
2008-01-06 12:41 ` Stefan Richter
2008-01-06 5:03 ` Al Boldi
2008-01-06 14:39 ` Stefan Richter
2008-01-06 17:07 ` Al Boldi [this message]
2008-01-06 17:50 ` Stefan Richter
2008-01-06 18:01 ` Stefan Richter
2008-01-06 18:23 ` Sam Ravnborg
2008-01-05 20:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801062007.31516.a1426z@gawab.com \
--to=a1426z@gawab.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.