All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: contradiction in boot/i386/pc/boot.S
Date: Tue, 8 Jan 2008 11:50:57 +0100	[thread overview]
Message-ID: <20080108105057.GA24604@thorin> (raw)


boot/i386/pc/boot.S reads:

        /*
         * This is a workaround for buggy BIOSes which don't pass boot
         * drive correctly. If GRUB is installed into a HDD, check if
         * DL is masked correctly. If not, assume that the BIOS passed
         * a bogus value and set DL to 0x80, since this is the only
         * possible boot drive. If GRUB is installed into a floppy,
         * this does nothing (only jump).
         */
boot_drive_check:
        jmp     1f      /* grub-setup may overwrite this jump */
        testb   $0x80, %dl
        jnz     1f
        movb    $0x80, %dl
1:

However, if 0x80 is really "the only possible boot drive", that means the
test is pointless and can be replaced with:

boot_drive_check:
        jmp     1f      /* grub-setup may overwrite this jump */
        movb    $0x80, %dl
1:

So AFAICT either the comment or the code needs adjusting.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)



             reply	other threads:[~2008-01-08 10:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 10:50 Robert Millan [this message]
2008-01-08 18:13 ` contradiction in boot/i386/pc/boot.S Pavel Roskin
2008-01-08 18:24 ` Pavel Roskin
2008-01-08 20:24   ` Robert Millan
2008-01-08 22:57     ` Pavel Roskin
2008-01-08 23:37       ` Robert Millan
2008-01-08 23:48         ` Vincent Pelletier
2008-01-08 23:51           ` Vincent Pelletier
2008-01-08 23:52         ` Pavel Roskin
2008-01-08 23:57           ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080108105057.GA24604@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.