From: Evgeniy Dushistov <dushistov@mail.ru>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3
Date: Tue, 8 Jan 2008 14:15:53 +0300 [thread overview]
Message-ID: <20080108111549.GA30832@rain> (raw)
In-Reply-To: <1195989865.3427.16.camel@localhost.localdomain>
On Sun, Nov 25, 2007 at 01:24:25PM +0200, James Bottomley wrote:
> This is a bit of a rash of bug fixes. The qla1280 is actually a bug fix
> (in spite of the title---it's actually correcting an existing problem
> with the qla1280 implementation of accessors that broke the current
> driver).
>
Recently I build last Linus's git tree, and got:
‘req_cnt’ is used uninitialized in this function,
and see bellow
> The patch is available here:
>
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
>
> The short changelog is:
...
> Jes Sorensen (1):
> qla1280: convert to use the data buffer accessors
>
...
> scsi/qla1280.c | 387 +++++++++++++++++++++----------------------------
...
> /* Calculate number of entries and segments required. */
> - req_cnt = 1;
>
Initilization of req_cnt was removed, but in this function
there are places like
req_cnt += (seg_cnt - 4) / 7;
or
req_cnt++;
This is should be so?
--
/Evgeniy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Dushistov <dushistov@mail.ru>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3
Date: Tue, 8 Jan 2008 14:15:53 +0300 [thread overview]
Message-ID: <20080108111549.GA30832@rain> (raw)
In-Reply-To: <1195989865.3427.16.camel@localhost.localdomain>
On Sun, Nov 25, 2007 at 01:24:25PM +0200, James Bottomley wrote:
> This is a bit of a rash of bug fixes. The qla1280 is actually a bug fix
> (in spite of the title---it's actually correcting an existing problem
> with the qla1280 implementation of accessors that broke the current
> driver).
>
Recently I build last Linus's git tree, and got:
‘req_cnt’ is used uninitialized in this function,
and see bellow
> The patch is available here:
>
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
>
> The short changelog is:
...
> Jes Sorensen (1):
> qla1280: convert to use the data buffer accessors
>
...
> scsi/qla1280.c | 387 +++++++++++++++++++++----------------------------
...
> /* Calculate number of entries and segments required. */
> - req_cnt = 1;
>
Initilization of req_cnt was removed, but in this function
there are places like
req_cnt += (seg_cnt - 4) / 7;
or
req_cnt++;
This is should be so?
--
/Evgeniy
next prev parent reply other threads:[~2008-01-08 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 11:24 [GIT PATCH] SCSI bug fixes for 2.6.24-rc3 James Bottomley
2008-01-08 11:15 ` Evgeniy Dushistov [this message]
2008-01-08 11:15 ` Evgeniy Dushistov
2008-01-08 14:07 ` FUJITA Tomonori
2008-01-08 14:07 ` FUJITA Tomonori
2008-01-09 18:45 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108111549.GA30832@rain \
--to=dushistov@mail.ru \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.