From: Matthew Wilcox <matthew@wil.cx>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: Jiri Kosina <jikos@jikos.cz>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl
Date: Thu, 10 Jan 2008 15:50:03 +0000 [thread overview]
Message-ID: <20080110155003.GD18741@parisc-linux.org> (raw)
In-Reply-To: <1199979101.4474.89.camel@nikanth-laptop.blr.novell.com>
On Thu, Jan 10, 2008 at 09:01:41PM +0530, Nikanth Karthikesan wrote:
> On Thu, 2008-01-10 at 16:01 +0100, Jiri Kosina wrote:
> > On Wed, 9 Jan 2008, Alan Cox wrote:
> >
> > > > > > default:
> > > > > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > > > > > + unlock_kernel();
> > > > > > return -EINVAL;
> > > > > Surely a bug ... shouldn't this return -ENOTTY?
> > > Agreed - ENOTTY.
> >
> > Just out of curiosity, where does POSIX happen to specify ENOTTY as the
> > correct one for unimplemented ioctl?
> >
>
> The printk is also wrong, It should have been, Invalid ioctl for the
> device
It shouldn't print anything. That printk lets unprivileged users DoS
the syslog.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: Jiri Kosina <jikos@jikos.cz>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl
Date: Thu, 10 Jan 2008 08:50:03 -0700 [thread overview]
Message-ID: <20080110155003.GD18741@parisc-linux.org> (raw)
In-Reply-To: <1199979101.4474.89.camel@nikanth-laptop.blr.novell.com>
On Thu, Jan 10, 2008 at 09:01:41PM +0530, Nikanth Karthikesan wrote:
> On Thu, 2008-01-10 at 16:01 +0100, Jiri Kosina wrote:
> > On Wed, 9 Jan 2008, Alan Cox wrote:
> >
> > > > > > default:
> > > > > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > > > > > + unlock_kernel();
> > > > > > return -EINVAL;
> > > > > Surely a bug ... shouldn't this return -ENOTTY?
> > > Agreed - ENOTTY.
> >
> > Just out of curiosity, where does POSIX happen to specify ENOTTY as the
> > correct one for unimplemented ioctl?
> >
>
> The printk is also wrong, It should have been, Invalid ioctl for the
> device
It shouldn't print anything. That printk lets unprivileged users DoS
the syslog.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-01-10 15:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 6:12 [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Nikanth Karthikesan
2008-01-10 6:14 ` Nikanth Karthikesan
2008-01-09 7:19 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Nikanth Karthikesan
2008-01-10 7:23 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Nikanth Karthikesan
2008-01-09 12:33 ` Matthew Wilcox
2008-01-09 12:33 ` Matthew Wilcox
2008-01-09 13:26 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Jiri Kosina
2008-01-09 13:26 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Jiri Kosina
2008-01-09 16:56 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Alan Cox
2008-01-09 16:56 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Alan Cox
2008-01-10 15:01 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Jiri Kosina
2008-01-10 15:01 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Jiri Kosina
2008-01-10 20:58 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Alan Cox
2008-01-10 20:58 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Alan Cox
[not found] ` <478681FE.BANGALORE.BLR.100.174746A.1.ECB1.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10 15:31 ` Nikanth Karthikesan
2008-01-10 15:43 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Nikanth Karthikesan
2008-01-10 15:50 ` Matthew Wilcox [this message]
2008-01-10 15:50 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Matthew Wilcox
[not found] ` <47854BF3.BANGALORE.BLR.100.174746A.1.EB89.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10 5:29 ` Nikanth Karthikesan
2008-01-10 5:41 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Nikanth Karthikesan
2008-01-09 8:06 ` Christoph Hellwig
2008-01-09 8:06 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Christoph Hellwig
2008-01-09 8:23 ` Valdis.Kletnieks
2008-01-09 8:23 ` Valdis.Kletnieks
[not found] ` <4784D3E0.BANGALORE.BLR.100.174746A.1.EABB.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-09 8:52 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Nikanth Karthikesan
2008-01-10 8:55 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Nikanth Karthikesan
2008-01-09 12:14 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Jan Engelhardt
2008-01-09 12:14 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Jan Engelhardt
2008-01-09 12:20 ` [PATCH] Change paride driver to use unlocked_ioctl instead of Christoph Hellwig
2008-01-09 12:20 ` [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110155003.GD18741@parisc-linux.org \
--to=matthew@wil.cx \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=grant@torque.net \
--cc=jikos@jikos.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.