From: Andi Kleen <andi@firstfloor.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andi Kleen <andi@firstfloor.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Andre Noll <maan@systemlinux.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl
Date: Thu, 10 Jan 2008 19:38:39 +0000 [thread overview]
Message-ID: <20080110193839.GA2120@one.firstfloor.org> (raw)
In-Reply-To: <20080110193321.GH18741@parisc-linux.org>
> If your goal is to get rid of the BKL everywhere, sure. It's not clear
> to me this is the most productive way of spending our time though.
I believe eventually eliminating ->ioctl (as opposed to ->unlocked_ioctl)
would be a productive thing to do. Still having implicit BKL semantics in
such an important interface is just wrong.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andi Kleen <andi@firstfloor.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Andre Noll <maan@systemlinux.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl
Date: Thu, 10 Jan 2008 20:38:39 +0100 [thread overview]
Message-ID: <20080110193839.GA2120@one.firstfloor.org> (raw)
In-Reply-To: <20080110193321.GH18741@parisc-linux.org>
> If your goal is to get rid of the BKL everywhere, sure. It's not clear
> to me this is the most productive way of spending our time though.
I believe eventually eliminating ->ioctl (as opposed to ->unlocked_ioctl)
would be a productive thing to do. Still having implicit BKL semantics in
such an important interface is just wrong.
-Andi
next prev parent reply other threads:[~2008-01-10 19:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 18:05 [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl Andre Noll
2008-01-10 18:05 ` Andre Noll
2008-01-10 18:54 ` [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to James Bottomley
2008-01-10 18:54 ` [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl James Bottomley
2008-01-10 18:59 ` Andi Kleen
2008-01-10 18:59 ` Andi Kleen
2008-01-10 19:03 ` Matthew Wilcox
2008-01-10 19:03 ` Matthew Wilcox
2008-01-10 19:21 ` Andi Kleen
2008-01-10 19:21 ` Andi Kleen
2008-01-10 19:03 ` [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to James Bottomley
2008-01-10 19:03 ` [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl James Bottomley
2008-01-10 19:32 ` Andi Kleen
2008-01-10 19:32 ` Andi Kleen
2008-01-10 19:33 ` Matthew Wilcox
2008-01-10 19:33 ` Matthew Wilcox
2008-01-10 19:38 ` Andi Kleen [this message]
2008-01-10 19:38 ` Andi Kleen
2008-01-10 19:07 ` Andre Noll
2008-01-10 19:07 ` Andre Noll
2008-01-10 19:29 ` Andi Kleen
2008-01-10 19:29 ` Andi Kleen
2008-01-10 19:45 ` Andre Noll
2008-01-10 19:45 ` Andre Noll
2008-01-10 20:09 ` [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to James Bottomley
2008-01-10 20:09 ` [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl James Bottomley
2008-01-10 20:13 ` Boaz Harrosh
2008-01-10 20:13 ` Boaz Harrosh
2008-01-10 20:40 ` Andre Noll
2008-01-10 20:40 ` Andre Noll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110193839.GA2120@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maan@systemlinux.org \
--cc=matthew@wil.cx \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.