From: Jens Axboe <jens.axboe@oracle.com>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: linux-btrace@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 1/1] blktrace: Add blktrace ioctls to SCSI generic devices
Date: Fri, 11 Jan 2008 09:11:42 +0000 [thread overview]
Message-ID: <20080111091142.GL6258@kernel.dk> (raw)
In-Reply-To: <20080107074647.784615000@de.ibm.com>
On Mon, Jan 07 2008, Christof Schmitt wrote:
> From: Christof Schmitt <christof.schmitt@de.ibm.com>
>
> Since the SCSI layer uses the request queues from the block layer, blktrace can
> also be used to trace the requests to all SCSI devices (like SCSI tape drives),
> not only disks. The only missing part is the ioctl interface to start and stop
> tracing.
>
> This patch adds the SETUP, START, STOP and TEARDOWN ioctls from blktrace to the
> sg device files. With this change, blktrace can be used for SCSI devices like
> for disks, e.g.: blktrace -d /dev/sg1 -o - | blkparse -i -
>
> Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Looks fine to me, queued up for 2.6.25.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: linux-btrace@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 1/1] blktrace: Add blktrace ioctls to SCSI generic devices
Date: Fri, 11 Jan 2008 10:11:42 +0100 [thread overview]
Message-ID: <20080111091142.GL6258@kernel.dk> (raw)
In-Reply-To: <20080107074647.784615000@de.ibm.com>
On Mon, Jan 07 2008, Christof Schmitt wrote:
> From: Christof Schmitt <christof.schmitt@de.ibm.com>
>
> Since the SCSI layer uses the request queues from the block layer, blktrace can
> also be used to trace the requests to all SCSI devices (like SCSI tape drives),
> not only disks. The only missing part is the ioctl interface to start and stop
> tracing.
>
> This patch adds the SETUP, START, STOP and TEARDOWN ioctls from blktrace to the
> sg device files. With this change, blktrace can be used for SCSI devices like
> for disks, e.g.: blktrace -d /dev/sg1 -o - | blkparse -i -
>
> Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Looks fine to me, queued up for 2.6.25.
--
Jens Axboe
next prev parent reply other threads:[~2008-01-11 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 7:45 [patch 0/1] Add blktrace interface to sg device files Christof Schmitt
2008-01-07 7:45 ` Christof Schmitt
2008-01-07 7:45 ` [patch 1/1] blktrace: Add blktrace ioctls to SCSI generic devices Christof Schmitt
2008-01-07 7:45 ` Christof Schmitt
2008-01-11 9:11 ` Jens Axboe [this message]
2008-01-11 9:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111091142.GL6258@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.