From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix CONFIG_FLASH_CFI_LEGACY compilation
Date: Sat, 12 Jan 2008 19:48:26 +0100 [thread overview]
Message-ID: <20080112184826.EE22024656@gemini.denx.de> (raw)
In-Reply-To: Your message of "Sat, 12 Jan 2008 14:43:01 +0100." <20080112134301.GA6978@discworld.dascon.de>
In message <20080112134301.GA6978@discworld.dascon.de> you wrote:
> On Sat, Jan 12, 2008 at 07:27:49AM +0100, Stefan Roese wrote:
> >
> > No. You CFI/JEDEC rework should be available in the official repository right
> > now. Could be that something slipped though. Best would be if you would
> > provide a patch that adds the missing JEDEC stuff.
>
> Okay - after a closer look, just a small change is required.
Hm... either you got the patch inverse, or something is seriously
broken:
> case CFI_CMDSET_INTEL_STANDARD:
> case CFI_CMDSET_INTEL_EXTENDED:
> - flash_read_jedec_ids_intel(info);
> + cmdset_amd_read_jedec_ids(info);
> break;
For INTEL flashes use the AMD command set, and ...
> case CFI_CMDSET_AMD_STANDARD:
> case CFI_CMDSET_AMD_EXTENDED:
> - flash_read_jedec_ids_amd(info);
> + cmdset_intel_read_jedec_ids(info);
...for AMD flashes use the INTEL command set?
This makes no sense to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If anything can go wrong, it will." - Edsel Murphy
next prev parent reply other threads:[~2008-01-12 18:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 21:36 [U-Boot-Users] CUSTODIANS: List of open issues / not applied patches Wolfgang Denk
2008-01-09 21:45 ` Timur Tabi
2008-01-09 21:47 ` Jerry Van Baren
2008-01-09 22:47 ` Andy Fleming
2008-01-09 23:17 ` Matthias Fuchs
2008-01-10 8:48 ` Haavard Skinnemoen
2008-01-10 10:50 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-10 15:34 ` Scott McNutt
2008-01-10 20:43 ` Ben Warren
2008-01-11 4:04 ` Kim Phillips
2008-01-11 10:06 ` Martin Krause
2008-01-11 21:06 ` Michael Schwingen
2008-01-12 6:27 ` Stefan Roese
2008-01-12 13:43 ` [U-Boot-Users] [PATCH] fix CONFIG_FLASH_CFI_LEGACY compilation Michael Schwingen
2008-01-12 18:48 ` Wolfgang Denk [this message]
2008-01-12 19:29 ` Michael Schwingen
2008-01-13 14:09 ` Stefan Roese
2008-01-14 8:01 ` [U-Boot-Users] CUSTODIANS: List of open issues / not applied patches Haavard Skinnemoen
2008-01-14 8:07 ` Michael Schwingen
2008-01-15 14:48 ` Shinya Kuribayashi
2008-01-16 10:16 ` Vlad Lungu
2008-01-16 12:16 ` Shinya Kuribayashi
2008-01-16 12:18 ` Vlad Lungu
2008-01-15 15:39 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080112184826.EE22024656@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.