[PATCH] remove 11c1:1040 from patch_si3054.c id list

[PATCH] remove 11c1:1040 from patch_si3054.c id list

[Vasily Khoruzhick]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Codec with id 11c1:1040 sitting on hda bus isn't si3054-compatible.
It should be removed from patch_si3054.c id list

[-- Attachment #2: remove_11c1_1040_from_si3054.patch --]
[-- Type: text/x-diff, Size: 583 bytes --]

--- patch_si3054.c.old	2008-01-13 16:17:54.000000000 +0200
+++ patch_si3054.c	2008-01-15 20:00:40.000000000 +0200
@@ -286,7 +286,6 @@
 struct hda_codec_preset snd_hda_preset_si3054[] = {
  	{ .id = 0x163c3055, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x163c3155, .name = "Si3054", .patch = patch_si3054 },
- 	{ .id = 0x11c11040, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x11c13026, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x11c13055, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x11c13155, .name = "Si3054", .patch = patch_si3054 },

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] remove 11c1:1040 from patch_si3054.c id list

[Takashi Iwai]

At Tue, 15 Jan 2008 20:04:19 +0200,
Vasily Khoruzhick wrote:
> 
> Codec with id 11c1:1040 sitting on hda bus isn't si3054-compatible.

Are you 100% sure that it isn't compatible?
It could be a driver bug, or some devices with the same id might
work.  It might be a mistaken that it's there but might be not.

We need more investigation before doing this.


Takashi