All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <andyw@uk.ibm.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: Make checkpatch.pl's quiet option not print the summary on no errors
Date: Tue, 15 Jan 2008 20:10:54 +0000	[thread overview]
Message-ID: <20080115201054.GC21511@shadowen.org> (raw)
In-Reply-To: <477C3252.1080001@linux.intel.com>

On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote:
> Subject: Make checkpatch.pl's quiet option not print the summary on no 
> errors
> From: Arjan van de Ven <arjan@linux.intel.com>
> CC: apw@uk.ibm.com
> 
> Right now, in quiet mode, checkpatch.pl still prints a summary line even
> if the patch is 100% clean. IMO, "quiet mode" should mean "no output if 
> clean",
> the patch below makes that so. (This also makes the quilt integration
> on my system work nicer :)
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

While looking to integrate this I discovered that the current default
was a desired feature requested by Ingo.  So I guess we need to come up
with a combination of options which give us both.

Currently we have --[no-]summary meaning suppress/add a summary, and
--quiet meaning suppress output but which does not suppress the summary.

We have a few options:

1) allow doubling of -q to make the summary subject to -q,
2) allow doubling of --summary to mean "override -q", --summary becoming
   subject to -q,
3) add a new option --force-summary which always produces a summary,
   --summary becoming subject to -q, and
4) add a new option --summary-on-fail which is subject to -q.

I feel the last of these is the most obvious option, and carries
no modification to current semantics.

Thoughts?

-apw

  parent reply	other threads:[~2008-01-15 20:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03  0:54 Make checkpatch.pl's quiet option not print the summary on no errors Arjan van de Ven
2008-01-03 13:09 ` Andy Whitcroft
2008-01-15 20:10 ` Andy Whitcroft [this message]
2008-01-15 21:58   ` Ingo Molnar
2008-01-16 11:06   ` Ingo Molnar
2008-01-17 17:05     ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080115201054.GC21511@shadowen.org \
    --to=andyw@uk.ibm.com \
    --cc=arjan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.