From: Arjan van de Ven <arjan@linux.intel.com>
To: apw@uk.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: Make checkpatch.pl's quiet option not print the summary on no errors
Date: Thu, 03 Jan 2008 01:54:42 +0100 [thread overview]
Message-ID: <477C3252.1080001@linux.intel.com> (raw)
Subject: Make checkpatch.pl's quiet option not print the summary on no errors
From: Arjan van de Ven <arjan@linux.intel.com>
CC: apw@uk.ibm.com
Right now, in quiet mode, checkpatch.pl still prints a summary line even
if the patch is 100% clean. IMO, "quiet mode" should mean "no output if clean",
the patch below makes that so. (This also makes the quilt integration
on my system work nicer :)
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.24-rc6/scripts/checkpatch.pl
===================================================================
--- linux-2.6.24-rc6.orig/scripts/checkpatch.pl
+++ linux-2.6.24-rc6/scripts/checkpatch.pl
@@ -1579,7 +1579,7 @@ sub process {
}
print report_dump();
- if ($summary) {
+ if ($summary && ($clean == 0 || $quiet == 0)) {
print "total: $cnt_error errors, $cnt_warn warnings, " .
(($check)? "$cnt_chk checks, " : "") .
"$cnt_lines lines checked\n";
next reply other threads:[~2008-01-03 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 0:54 Arjan van de Ven [this message]
2008-01-03 13:09 ` Make checkpatch.pl's quiet option not print the summary on no errors Andy Whitcroft
2008-01-15 20:10 ` Andy Whitcroft
2008-01-15 21:58 ` Ingo Molnar
2008-01-16 11:06 ` Ingo Molnar
2008-01-17 17:05 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477C3252.1080001@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=apw@uk.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.