All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
	Len Brown <lenb@kernel.org>, Andrew Morton <akpm@osdl.org>,
	"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: [PATCH] Ignore ACPI video devices that aren't present in hardware
Date: Thu, 17 Jan 2008 12:02:38 +0000	[thread overview]
Message-ID: <20080117120237.GA31912@srcf.ucam.org> (raw)
In-Reply-To: <1200567431.23376.459.camel@queen.suse.de>

On Thu, Jan 17, 2008 at 11:57:11AM +0100, Thomas Renninger wrote:

> Does it make sense to add this as a separate function, searching for a
> physical PCI device for an ACPI device may pop up more often in the
> future? This is a kind of _STA (present or not) function for PCI ACPI
> devices then.

No, I don't think this can be done generically - _ADR for a SATA device 
has a format that looks similar to the one for PCI devices, for 
instance. I think you need to have knowledge of the specific device 
type.

> This has been tested on a Dell 610 only then?
> This sounds like an older machine, I wonder whether the video driver is
> useful on this one at all and whether Windows had to check whether the
> devices are present also...

Also on an HP 2510p. I suspect that the Windows behaviour is to leave 
this up to the graphics driver rather than handling it in the core. 
Toshiba seem to have implemented the complete spec for some time, but 
several other vendors only implemented the section for display output 
switching and obtaining the EDID.

> Please tell me if you have tested more machines, I try to give it a test
> on a Toshiba, Lenovo and whatever I find with a Vista capable BIOS (IMO
> this should be the most important criterion for finding the devices, I
> doubt older Windows Versions made much use of ACPI graphics devices) as
> soon as I find some time...

Yes, I've tested it on some other machines - the HP is the only one I've 
tested with a designed for Vista badge, but it should be correct in 
these cases as well.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2008-01-17 12:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-07 12:55 [PATCH] Recent Lenovo ThinkPads define a dummy grahpics device, find it and ignore it Thomas Renninger
2007-12-07 15:27 ` Thomas Renninger
2007-12-07 22:50 ` Matthew Garrett
2007-12-10 12:48   ` Thomas Renninger
2008-01-17  3:11     ` Matthew Garrett
2008-01-17  3:39       ` [PATCH] Ignore ACPI video devices that aren't present in hardware Matthew Garrett
2008-01-17 10:57         ` Thomas Renninger
2008-01-17 12:02           ` Matthew Garrett [this message]
2008-01-22  8:52             ` Zhang Rui
2008-01-22 12:11               ` Julian Sikorski
2008-01-24 22:21         ` Len Brown
2008-01-27  2:09           ` Matthew Garrett
2008-02-02  7:12             ` Len Brown
2008-02-03  0:03               ` Matthew Garrett
2008-02-07  1:44                 ` Matthew Garrett
2008-02-07  7:03                   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080117120237.GA31912@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=akpm@osdl.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.