From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: Thomas Renninger <trenn@suse.de>,
linux-acpi <linux-acpi@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: [PATCH] Ignore ACPI video devices that aren't present in hardware
Date: Sun, 27 Jan 2008 02:09:20 +0000 [thread overview]
Message-ID: <20080127020920.GB10173@srcf.ucam.org> (raw)
In-Reply-To: <200801241721.17436.lenb@kernel.org>
On Thu, Jan 24, 2008 at 05:21:17PM -0500, Len Brown wrote:
> _ADR returns a bus-specific format.
> In the case of a video device, section B.6.1 says that
> _ADR returns a 32-bit device ID, and that
No, that's only true for the output devices - not the parent device. The
parent device is what's interesting here, and the format of its _ADR
method is not defined.
> So I don't think you can use the numerical value returned
> to have any particular meaning at all.
> In particular, comparing it to magic number 0x10000 makes no sense.
In practice, it's either going to be a PCI device ID or something
custom. If it's custom, it's unlikely to be a PCI device ID. From that
point of view, 0x10000 isn't magic - it's the lowest PCI device ID that
stands a real chance of being the graphics hardware or bridge that the
graphics hardware is attached to.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-01-27 2:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 12:55 [PATCH] Recent Lenovo ThinkPads define a dummy grahpics device, find it and ignore it Thomas Renninger
2007-12-07 15:27 ` Thomas Renninger
2007-12-07 22:50 ` Matthew Garrett
2007-12-10 12:48 ` Thomas Renninger
2008-01-17 3:11 ` Matthew Garrett
2008-01-17 3:39 ` [PATCH] Ignore ACPI video devices that aren't present in hardware Matthew Garrett
2008-01-17 10:57 ` Thomas Renninger
2008-01-17 12:02 ` Matthew Garrett
2008-01-22 8:52 ` Zhang Rui
2008-01-22 12:11 ` Julian Sikorski
2008-01-24 22:21 ` Len Brown
2008-01-27 2:09 ` Matthew Garrett [this message]
2008-02-02 7:12 ` Len Brown
2008-02-03 0:03 ` Matthew Garrett
2008-02-07 1:44 ` Matthew Garrett
2008-02-07 7:03 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080127020920.GB10173@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@osdl.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.