All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] hwmon: (vt8231) Add individual alarm files
@ 2008-01-06 14:46 Jean Delvare
  2008-01-06 17:22 ` Roger Lucas
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Jean Delvare @ 2008-01-06 14:46 UTC (permalink / raw)
  To: lm-sensors

The new libsensors needs these individual alarm files.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Roger Lucas <roger@planbit.co.uk>
---
Roger, can you please test and/or review this patch?

 drivers/hwmon/vt8231.c |   40 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

--- linux-2.6.24-rc6.orig/drivers/hwmon/vt8231.c	2007-12-26 14:39:06.000000000 +0100
+++ linux-2.6.24-rc6/drivers/hwmon/vt8231.c	2008-01-01 19:22:37.000000000 +0100
@@ -541,6 +541,28 @@ static ssize_t show_alarms(struct device
 }
 static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
 
+static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
+			  char *buf)
+{
+	int bitnr = to_sensor_dev_attr(attr)->index;
+	struct vt8231_data *data = vt8231_update_device(dev);
+	return sprintf(buf, "%u\n", (data->alarms >> bitnr) & 1);
+}
+static SENSOR_DEVICE_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL, 4);
+static SENSOR_DEVICE_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL, 11);
+static SENSOR_DEVICE_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL, 0);
+static SENSOR_DEVICE_ATTR(temp4_alarm, S_IRUGO, show_alarm, NULL, 1);
+static SENSOR_DEVICE_ATTR(temp5_alarm, S_IRUGO, show_alarm, NULL, 3);
+static SENSOR_DEVICE_ATTR(temp6_alarm, S_IRUGO, show_alarm, NULL, 8);
+static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, show_alarm, NULL, 11);
+static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, show_alarm, NULL, 0);
+static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, show_alarm, NULL, 1);
+static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, show_alarm, NULL, 3);
+static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 8);
+static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 2);
+static SENSOR_DEVICE_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, 6);
+static SENSOR_DEVICE_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, 7);
+
 static ssize_t show_name(struct device *dev, struct device_attribute
 			 *devattr, char *buf)
 {
@@ -549,36 +571,42 @@ static ssize_t show_name(struct device *
 }
 static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
 
-static struct attribute *vt8231_attributes_temps[6][4] = {
+static struct attribute *vt8231_attributes_temps[6][5] = {
 	{
 		&dev_attr_temp1_input.attr,
 		&dev_attr_temp1_max_hyst.attr,
 		&dev_attr_temp1_max.attr,
+		&sensor_dev_attr_temp1_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_temp2_input.dev_attr.attr,
 		&sensor_dev_attr_temp2_max_hyst.dev_attr.attr,
 		&sensor_dev_attr_temp2_max.dev_attr.attr,
+		&sensor_dev_attr_temp2_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_temp3_input.dev_attr.attr,
 		&sensor_dev_attr_temp3_max_hyst.dev_attr.attr,
 		&sensor_dev_attr_temp3_max.dev_attr.attr,
+		&sensor_dev_attr_temp3_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_temp4_input.dev_attr.attr,
 		&sensor_dev_attr_temp4_max_hyst.dev_attr.attr,
 		&sensor_dev_attr_temp4_max.dev_attr.attr,
+		&sensor_dev_attr_temp4_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_temp5_input.dev_attr.attr,
 		&sensor_dev_attr_temp5_max_hyst.dev_attr.attr,
 		&sensor_dev_attr_temp5_max.dev_attr.attr,
+		&sensor_dev_attr_temp5_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_temp6_input.dev_attr.attr,
 		&sensor_dev_attr_temp6_max_hyst.dev_attr.attr,
 		&sensor_dev_attr_temp6_max.dev_attr.attr,
+		&sensor_dev_attr_temp6_alarm.dev_attr.attr,
 		NULL
 	}
 };
@@ -592,36 +620,42 @@ static const struct attribute_group vt82
 	{ .attrs = vt8231_attributes_temps[5] },
 };
 
-static struct attribute *vt8231_attributes_volts[6][4] = {
+static struct attribute *vt8231_attributes_volts[6][5] = {
 	{
 		&sensor_dev_attr_in0_input.dev_attr.attr,
 		&sensor_dev_attr_in0_min.dev_attr.attr,
 		&sensor_dev_attr_in0_max.dev_attr.attr,
+		&sensor_dev_attr_in0_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_in1_input.dev_attr.attr,
 		&sensor_dev_attr_in1_min.dev_attr.attr,
 		&sensor_dev_attr_in1_max.dev_attr.attr,
+		&sensor_dev_attr_in1_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_in2_input.dev_attr.attr,
 		&sensor_dev_attr_in2_min.dev_attr.attr,
 		&sensor_dev_attr_in2_max.dev_attr.attr,
+		&sensor_dev_attr_in2_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_in3_input.dev_attr.attr,
 		&sensor_dev_attr_in3_min.dev_attr.attr,
 		&sensor_dev_attr_in3_max.dev_attr.attr,
+		&sensor_dev_attr_in3_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&sensor_dev_attr_in4_input.dev_attr.attr,
 		&sensor_dev_attr_in4_min.dev_attr.attr,
 		&sensor_dev_attr_in4_max.dev_attr.attr,
+		&sensor_dev_attr_in4_alarm.dev_attr.attr,
 		NULL
 	}, {
 		&dev_attr_in5_input.attr,
 		&dev_attr_in5_min.attr,
 		&dev_attr_in5_max.attr,
+		&sensor_dev_attr_in5_alarm.dev_attr.attr,
 		NULL
 	}
 };
@@ -642,6 +676,8 @@ static struct attribute *vt8231_attribut
 	&sensor_dev_attr_fan2_min.dev_attr.attr,
 	&sensor_dev_attr_fan1_div.dev_attr.attr,
 	&sensor_dev_attr_fan2_div.dev_attr.attr,
+	&sensor_dev_attr_fan1_alarm.dev_attr.attr,
+	&sensor_dev_attr_fan2_alarm.dev_attr.attr,
 	&dev_attr_alarms.attr,
 	&dev_attr_name.attr,
 	NULL


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
@ 2008-01-06 17:22 ` Roger Lucas
  2008-01-17  0:05 ` Roger Lucas
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Roger Lucas @ 2008-01-06 17:22 UTC (permalink / raw)
  To: lm-sensors

Hi Jean,

I'll check it on the hardware this week - I will probably not get a chance until Wed/Thu though...

- Roger

> -----Original Message-----
> From: Jean Delvare [mailto:khali@linux-fr.org]
> Sent: 06 January 2008 14:46
> To: LM Sensors; Roger Lucas
> Subject: hwmon: (vt8231) Add individual alarm files
> 
> The new libsensors needs these individual alarm files.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Roger Lucas <roger@planbit.co.uk>
> ---
> Roger, can you please test and/or review this patch?
> 
>  drivers/hwmon/vt8231.c |   40 ++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 38 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.24-rc6.orig/drivers/hwmon/vt8231.c	2007-12-26 14:39:06.000000000 +0100
> +++ linux-2.6.24-rc6/drivers/hwmon/vt8231.c	2008-01-01 19:22:37.000000000 +0100
> @@ -541,6 +541,28 @@ static ssize_t show_alarms(struct device
>  }
>  static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
> 
> +static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
> +			  char *buf)
> +{
> +	int bitnr = to_sensor_dev_attr(attr)->index;
> +	struct vt8231_data *data = vt8231_update_device(dev);
> +	return sprintf(buf, "%u\n", (data->alarms >> bitnr) & 1);
> +}
> +static SENSOR_DEVICE_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL, 4);
> +static SENSOR_DEVICE_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL, 11);
> +static SENSOR_DEVICE_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL, 0);
> +static SENSOR_DEVICE_ATTR(temp4_alarm, S_IRUGO, show_alarm, NULL, 1);
> +static SENSOR_DEVICE_ATTR(temp5_alarm, S_IRUGO, show_alarm, NULL, 3);
> +static SENSOR_DEVICE_ATTR(temp6_alarm, S_IRUGO, show_alarm, NULL, 8);
> +static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, show_alarm, NULL, 11);
> +static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, show_alarm, NULL, 0);
> +static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, show_alarm, NULL, 1);
> +static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, show_alarm, NULL, 3);
> +static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 8);
> +static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 2);
> +static SENSOR_DEVICE_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, 6);
> +static SENSOR_DEVICE_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, 7);
> +
>  static ssize_t show_name(struct device *dev, struct device_attribute
>  			 *devattr, char *buf)
>  {
> @@ -549,36 +571,42 @@ static ssize_t show_name(struct device *
>  }
>  static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
> 
> -static struct attribute *vt8231_attributes_temps[6][4] = {
> +static struct attribute *vt8231_attributes_temps[6][5] = {
>  	{
>  		&dev_attr_temp1_input.attr,
>  		&dev_attr_temp1_max_hyst.attr,
>  		&dev_attr_temp1_max.attr,
> +		&sensor_dev_attr_temp1_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp2_input.dev_attr.attr,
>  		&sensor_dev_attr_temp2_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp2_max.dev_attr.attr,
> +		&sensor_dev_attr_temp2_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp3_input.dev_attr.attr,
>  		&sensor_dev_attr_temp3_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp3_max.dev_attr.attr,
> +		&sensor_dev_attr_temp3_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp4_input.dev_attr.attr,
>  		&sensor_dev_attr_temp4_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp4_max.dev_attr.attr,
> +		&sensor_dev_attr_temp4_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp5_input.dev_attr.attr,
>  		&sensor_dev_attr_temp5_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp5_max.dev_attr.attr,
> +		&sensor_dev_attr_temp5_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp6_input.dev_attr.attr,
>  		&sensor_dev_attr_temp6_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp6_max.dev_attr.attr,
> +		&sensor_dev_attr_temp6_alarm.dev_attr.attr,
>  		NULL
>  	}
>  };
> @@ -592,36 +620,42 @@ static const struct attribute_group vt82
>  	{ .attrs = vt8231_attributes_temps[5] },
>  };
> 
> -static struct attribute *vt8231_attributes_volts[6][4] = {
> +static struct attribute *vt8231_attributes_volts[6][5] = {
>  	{
>  		&sensor_dev_attr_in0_input.dev_attr.attr,
>  		&sensor_dev_attr_in0_min.dev_attr.attr,
>  		&sensor_dev_attr_in0_max.dev_attr.attr,
> +		&sensor_dev_attr_in0_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in1_input.dev_attr.attr,
>  		&sensor_dev_attr_in1_min.dev_attr.attr,
>  		&sensor_dev_attr_in1_max.dev_attr.attr,
> +		&sensor_dev_attr_in1_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in2_input.dev_attr.attr,
>  		&sensor_dev_attr_in2_min.dev_attr.attr,
>  		&sensor_dev_attr_in2_max.dev_attr.attr,
> +		&sensor_dev_attr_in2_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in3_input.dev_attr.attr,
>  		&sensor_dev_attr_in3_min.dev_attr.attr,
>  		&sensor_dev_attr_in3_max.dev_attr.attr,
> +		&sensor_dev_attr_in3_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in4_input.dev_attr.attr,
>  		&sensor_dev_attr_in4_min.dev_attr.attr,
>  		&sensor_dev_attr_in4_max.dev_attr.attr,
> +		&sensor_dev_attr_in4_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&dev_attr_in5_input.attr,
>  		&dev_attr_in5_min.attr,
>  		&dev_attr_in5_max.attr,
> +		&sensor_dev_attr_in5_alarm.dev_attr.attr,
>  		NULL
>  	}
>  };
> @@ -642,6 +676,8 @@ static struct attribute *vt8231_attribut
>  	&sensor_dev_attr_fan2_min.dev_attr.attr,
>  	&sensor_dev_attr_fan1_div.dev_attr.attr,
>  	&sensor_dev_attr_fan2_div.dev_attr.attr,
> +	&sensor_dev_attr_fan1_alarm.dev_attr.attr,
> +	&sensor_dev_attr_fan2_alarm.dev_attr.attr,
>  	&dev_attr_alarms.attr,
>  	&dev_attr_name.attr,
>  	NULL
> 
> 
> --
> Jean Delvare


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
  2008-01-06 17:22 ` Roger Lucas
@ 2008-01-17  0:05 ` Roger Lucas
  2008-01-17 11:35 ` Jean Delvare
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Roger Lucas @ 2008-01-17  0:05 UTC (permalink / raw)
  To: lm-sensors

Hi Jean,

Sorry for the slow reply - I have finally had a chance to test your changes on the most recent 2.6.24-rc8 kernel.

I have checked all the voltage, fan and temperature alarms and they work as expected.  I only have one temperature
sensor on my motherboard so I was not able to test the alarms for temperatures 2 through 6, but the code looks correct
so I would be very surprised if they did not work properly.

My mail address is changing soon so I have a patch below to correct my e-mail addresses in the source code.  I have a
special address for the vt8231 kernel development so that I can filter the spam on it more aggressively - it does seem
to get heavily harvested...

Thanks for your work preparing this patch - 100% right first time :-)

Best regards,

Roger Lucas


Signed-off-by: Roger Lucas <vt8231@hiddenengine.co.uk>

--- linux-2.6.24-rc8-orig/drivers/hwmon/vt8231.c        2008-01-16 22:59:25.000000000 +0000
+++ linux-2.6.24-rc8/drivers/hwmon/vt8231.c     2008-01-16 23:57:27.000000000 +0000
@@ -2,7 +2,7 @@
        vt8231.c - Part of lm_sensors, Linux kernel modules
                                for hardware monitoring

-       Copyright (c) 2005 Roger Lucas <roger@planbit.co.uk>
+       Copyright (c) 2005 Roger Lucas <vt8231@hiddenengine.co.uk>
        Copyright (c) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
                           Aaron M. Marsh <amarsh@sdf.lonestar.org>

@@ -999,7 +999,7 @@
        }
 }

-MODULE_AUTHOR("Roger Lucas <roger@planbit.co.uk>");
+MODULE_AUTHOR("Roger Lucas <vt8231@hiddenengine.co.uk>");
 MODULE_DESCRIPTION("VT8231 sensors");
 MODULE_LICENSE("GPL");



> -----Original Message-----
> From: Jean Delvare [mailto:khali@linux-fr.org]
> Sent: 06 January 2008 14:46
> To: LM Sensors; Roger Lucas
> Subject: hwmon: (vt8231) Add individual alarm files
> 
> The new libsensors needs these individual alarm files.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Roger Lucas <roger@planbit.co.uk>
> ---
> Roger, can you please test and/or review this patch?
> 
>  drivers/hwmon/vt8231.c |   40 ++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 38 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.24-rc6.orig/drivers/hwmon/vt8231.c	2007-12-26 14:39:06.000000000 +0100
> +++ linux-2.6.24-rc6/drivers/hwmon/vt8231.c	2008-01-01 19:22:37.000000000 +0100
> @@ -541,6 +541,28 @@ static ssize_t show_alarms(struct device
>  }
>  static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
> 
> +static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
> +			  char *buf)
> +{
> +	int bitnr = to_sensor_dev_attr(attr)->index;
> +	struct vt8231_data *data = vt8231_update_device(dev);
> +	return sprintf(buf, "%u\n", (data->alarms >> bitnr) & 1);
> +}
> +static SENSOR_DEVICE_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL, 4);
> +static SENSOR_DEVICE_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL, 11);
> +static SENSOR_DEVICE_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL, 0);
> +static SENSOR_DEVICE_ATTR(temp4_alarm, S_IRUGO, show_alarm, NULL, 1);
> +static SENSOR_DEVICE_ATTR(temp5_alarm, S_IRUGO, show_alarm, NULL, 3);
> +static SENSOR_DEVICE_ATTR(temp6_alarm, S_IRUGO, show_alarm, NULL, 8);
> +static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, show_alarm, NULL, 11);
> +static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, show_alarm, NULL, 0);
> +static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, show_alarm, NULL, 1);
> +static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, show_alarm, NULL, 3);
> +static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 8);
> +static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 2);
> +static SENSOR_DEVICE_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, 6);
> +static SENSOR_DEVICE_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, 7);
> +
>  static ssize_t show_name(struct device *dev, struct device_attribute
>  			 *devattr, char *buf)
>  {
> @@ -549,36 +571,42 @@ static ssize_t show_name(struct device *
>  }
>  static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
> 
> -static struct attribute *vt8231_attributes_temps[6][4] = {
> +static struct attribute *vt8231_attributes_temps[6][5] = {
>  	{
>  		&dev_attr_temp1_input.attr,
>  		&dev_attr_temp1_max_hyst.attr,
>  		&dev_attr_temp1_max.attr,
> +		&sensor_dev_attr_temp1_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp2_input.dev_attr.attr,
>  		&sensor_dev_attr_temp2_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp2_max.dev_attr.attr,
> +		&sensor_dev_attr_temp2_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp3_input.dev_attr.attr,
>  		&sensor_dev_attr_temp3_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp3_max.dev_attr.attr,
> +		&sensor_dev_attr_temp3_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp4_input.dev_attr.attr,
>  		&sensor_dev_attr_temp4_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp4_max.dev_attr.attr,
> +		&sensor_dev_attr_temp4_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp5_input.dev_attr.attr,
>  		&sensor_dev_attr_temp5_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp5_max.dev_attr.attr,
> +		&sensor_dev_attr_temp5_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_temp6_input.dev_attr.attr,
>  		&sensor_dev_attr_temp6_max_hyst.dev_attr.attr,
>  		&sensor_dev_attr_temp6_max.dev_attr.attr,
> +		&sensor_dev_attr_temp6_alarm.dev_attr.attr,
>  		NULL
>  	}
>  };
> @@ -592,36 +620,42 @@ static const struct attribute_group vt82
>  	{ .attrs = vt8231_attributes_temps[5] },
>  };
> 
> -static struct attribute *vt8231_attributes_volts[6][4] = {
> +static struct attribute *vt8231_attributes_volts[6][5] = {
>  	{
>  		&sensor_dev_attr_in0_input.dev_attr.attr,
>  		&sensor_dev_attr_in0_min.dev_attr.attr,
>  		&sensor_dev_attr_in0_max.dev_attr.attr,
> +		&sensor_dev_attr_in0_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in1_input.dev_attr.attr,
>  		&sensor_dev_attr_in1_min.dev_attr.attr,
>  		&sensor_dev_attr_in1_max.dev_attr.attr,
> +		&sensor_dev_attr_in1_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in2_input.dev_attr.attr,
>  		&sensor_dev_attr_in2_min.dev_attr.attr,
>  		&sensor_dev_attr_in2_max.dev_attr.attr,
> +		&sensor_dev_attr_in2_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in3_input.dev_attr.attr,
>  		&sensor_dev_attr_in3_min.dev_attr.attr,
>  		&sensor_dev_attr_in3_max.dev_attr.attr,
> +		&sensor_dev_attr_in3_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&sensor_dev_attr_in4_input.dev_attr.attr,
>  		&sensor_dev_attr_in4_min.dev_attr.attr,
>  		&sensor_dev_attr_in4_max.dev_attr.attr,
> +		&sensor_dev_attr_in4_alarm.dev_attr.attr,
>  		NULL
>  	}, {
>  		&dev_attr_in5_input.attr,
>  		&dev_attr_in5_min.attr,
>  		&dev_attr_in5_max.attr,
> +		&sensor_dev_attr_in5_alarm.dev_attr.attr,
>  		NULL
>  	}
>  };
> @@ -642,6 +676,8 @@ static struct attribute *vt8231_attribut
>  	&sensor_dev_attr_fan2_min.dev_attr.attr,
>  	&sensor_dev_attr_fan1_div.dev_attr.attr,
>  	&sensor_dev_attr_fan2_div.dev_attr.attr,
> +	&sensor_dev_attr_fan1_alarm.dev_attr.attr,
> +	&sensor_dev_attr_fan2_alarm.dev_attr.attr,
>  	&dev_attr_alarms.attr,
>  	&dev_attr_name.attr,
>  	NULL
> 
> 
> --
> Jean Delvare


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
  2008-01-06 17:22 ` Roger Lucas
  2008-01-17  0:05 ` Roger Lucas
@ 2008-01-17 11:35 ` Jean Delvare
  2008-02-10  7:06 ` Juerg Haefliger
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2008-01-17 11:35 UTC (permalink / raw)
  To: lm-sensors

Hi Roger,

On Thu, 17 Jan 2008 00:05:28 -0000, Roger Lucas wrote:
> Sorry for the slow reply - I have finally had a chance to test your
> changes on the most recent 2.6.24-rc8 kernel.
> 
> I have checked all the voltage, fan and temperature alarms and
> they work as expected.  I only have one temperature sensor on my
> motherboard so I was not able to test the alarms for temperatures 2
> through 6, but the code looks correct so I would be very surprised
> if they did not work properly.

OK, thanks for testing. Mark, can you please apply my patch to your
testing tree?

> My mail address is changing soon so I have a patch below to correct
> my e-mail addresses in the source code.  I have a special address for
> the vt8231 kernel development so that I can filter the spam on it more
> aggressively - it does seem to get heavily harvested...
> (...)
> Signed-off-by: Roger Lucas <vt8231@hiddenengine.co.uk>
> 
> --- linux-2.6.24-rc8-orig/drivers/hwmon/vt8231.c        2008-01-16 22:59:25.000000000 +0000
> +++ linux-2.6.24-rc8/drivers/hwmon/vt8231.c     2008-01-16 23:57:27.000000000 +0000
> @@ -2,7 +2,7 @@
>         vt8231.c - Part of lm_sensors, Linux kernel modules
>                                 for hardware monitoring
> 
> -       Copyright (c) 2005 Roger Lucas <roger@planbit.co.uk>
> +       Copyright (c) 2005 Roger Lucas <vt8231@hiddenengine.co.uk>
>         Copyright (c) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
>                            Aaron M. Marsh <amarsh@sdf.lonestar.org>
> 
> @@ -999,7 +999,7 @@
>         }
>  }
> 
> -MODULE_AUTHOR("Roger Lucas <roger@planbit.co.uk>");
> +MODULE_AUTHOR("Roger Lucas <vt8231@hiddenengine.co.uk>");
>  MODULE_DESCRIPTION("VT8231 sensors");
>  MODULE_LICENSE("GPL");

You probably want to update your address in MAINTAINERS as well.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
                   ` (2 preceding siblings ...)
  2008-01-17 11:35 ` Jean Delvare
@ 2008-02-10  7:06 ` Juerg Haefliger
  2008-02-13 12:57 ` Mark M. Hoffman
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Juerg Haefliger @ 2008-02-10  7:06 UTC (permalink / raw)
  To: lm-sensors

Looks good - assuming the bit positions are correct, which I can't
verify without a datasheet - and compiles cleanly.

Acked-by: Juerg Haefliger <juergh at gmail.com>


> The new libsensors needs these individual alarm files.
>
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> Cc: Roger Lucas <roger at planbit.co.uk>
> ---
> Roger, can you please test and/or review this patch?
>
>   drivers/hwmon/vt8231.c |   40 ++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 38 insertions(+), 2 deletions(-)
>
> --- linux-2.6.24-rc6.orig/drivers/hwmon/vt8231.c        2007-12-26
> 14:39:06.000000000 +0100
> +++ linux-2.6.24-rc6/drivers/hwmon/vt8231.c     2008-01-01
> 19:22:37.000000000 +0100
> @@ -541,6 +541,28 @@ static ssize_t show_alarms(struct device
>   }
>   static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
>
> +static ssize_t show_alarm(struct device *dev, struct device_attribute
> *attr,
> +                         char *buf)
> +{
> +       int bitnr = to_sensor_dev_attr(attr)->index;
> +       struct vt8231_data *data = vt8231_update_device(dev);
> +       return sprintf(buf, "%u\n", (data->alarms >> bitnr) & 1);
> +}
> +static SENSOR_DEVICE_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL, 4);
> +static SENSOR_DEVICE_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL, 11);
> +static SENSOR_DEVICE_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL, 0);
> +static SENSOR_DEVICE_ATTR(temp4_alarm, S_IRUGO, show_alarm, NULL, 1);
> +static SENSOR_DEVICE_ATTR(temp5_alarm, S_IRUGO, show_alarm, NULL, 3);
> +static SENSOR_DEVICE_ATTR(temp6_alarm, S_IRUGO, show_alarm, NULL, 8);
> +static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, show_alarm, NULL, 11);
> +static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, show_alarm, NULL, 0);
> +static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, show_alarm, NULL, 1);
> +static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, show_alarm, NULL, 3);
> +static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 8);
> +static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 2);
> +static SENSOR_DEVICE_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, 6);
> +static SENSOR_DEVICE_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, 7);
> +
>   static ssize_t show_name(struct device *dev, struct device_attribute
>                          *devattr, char *buf)
>   {
> @@ -549,36 +571,42 @@ static ssize_t show_name(struct device *
>   }
>   static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
>
> -static struct attribute *vt8231_attributes_temps[6][4] = {
> +static struct attribute *vt8231_attributes_temps[6][5] = {
>         {
>                 &dev_attr_temp1_input.attr,
>                 &dev_attr_temp1_max_hyst.attr,
>                 &dev_attr_temp1_max.attr,
> +               &sensor_dev_attr_temp1_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_temp2_input.dev_attr.attr,
>                 &sensor_dev_attr_temp2_max_hyst.dev_attr.attr,
>                 &sensor_dev_attr_temp2_max.dev_attr.attr,
> +               &sensor_dev_attr_temp2_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_temp3_input.dev_attr.attr,
>                 &sensor_dev_attr_temp3_max_hyst.dev_attr.attr,
>                 &sensor_dev_attr_temp3_max.dev_attr.attr,
> +               &sensor_dev_attr_temp3_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_temp4_input.dev_attr.attr,
>                 &sensor_dev_attr_temp4_max_hyst.dev_attr.attr,
>                 &sensor_dev_attr_temp4_max.dev_attr.attr,
> +               &sensor_dev_attr_temp4_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_temp5_input.dev_attr.attr,
>                 &sensor_dev_attr_temp5_max_hyst.dev_attr.attr,
>                 &sensor_dev_attr_temp5_max.dev_attr.attr,
> +               &sensor_dev_attr_temp5_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_temp6_input.dev_attr.attr,
>                 &sensor_dev_attr_temp6_max_hyst.dev_attr.attr,
>                 &sensor_dev_attr_temp6_max.dev_attr.attr,
> +               &sensor_dev_attr_temp6_alarm.dev_attr.attr,
>                 NULL
>         }
>   };
> @@ -592,36 +620,42 @@ static const struct attribute_group vt82
>         { .attrs = vt8231_attributes_temps[5] },
>   };
>
> -static struct attribute *vt8231_attributes_volts[6][4] = {
> +static struct attribute *vt8231_attributes_volts[6][5] = {
>         {
>                 &sensor_dev_attr_in0_input.dev_attr.attr,
>                 &sensor_dev_attr_in0_min.dev_attr.attr,
>                 &sensor_dev_attr_in0_max.dev_attr.attr,
> +               &sensor_dev_attr_in0_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_in1_input.dev_attr.attr,
>                 &sensor_dev_attr_in1_min.dev_attr.attr,
>                 &sensor_dev_attr_in1_max.dev_attr.attr,
> +               &sensor_dev_attr_in1_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_in2_input.dev_attr.attr,
>                 &sensor_dev_attr_in2_min.dev_attr.attr,
>                 &sensor_dev_attr_in2_max.dev_attr.attr,
> +               &sensor_dev_attr_in2_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_in3_input.dev_attr.attr,
>                 &sensor_dev_attr_in3_min.dev_attr.attr,
>                 &sensor_dev_attr_in3_max.dev_attr.attr,
> +               &sensor_dev_attr_in3_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &sensor_dev_attr_in4_input.dev_attr.attr,
>                 &sensor_dev_attr_in4_min.dev_attr.attr,
>                 &sensor_dev_attr_in4_max.dev_attr.attr,
> +               &sensor_dev_attr_in4_alarm.dev_attr.attr,
>                 NULL
>         }, {
>                 &dev_attr_in5_input.attr,
>                 &dev_attr_in5_min.attr,
>                 &dev_attr_in5_max.attr,
> +               &sensor_dev_attr_in5_alarm.dev_attr.attr,
>                 NULL
>         }
>   };
> @@ -642,6 +676,8 @@ static struct attribute *vt8231_attribut
>         &sensor_dev_attr_fan2_min.dev_attr.attr,
>         &sensor_dev_attr_fan1_div.dev_attr.attr,
>         &sensor_dev_attr_fan2_div.dev_attr.attr,
> +       &sensor_dev_attr_fan1_alarm.dev_attr.attr,
> +       &sensor_dev_attr_fan2_alarm.dev_attr.attr,
>         &dev_attr_alarms.attr,
>         &dev_attr_name.attr,
>         NULL
>
>
> --
> Jean Delvare
>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
                   ` (3 preceding siblings ...)
  2008-02-10  7:06 ` Juerg Haefliger
@ 2008-02-13 12:57 ` Mark M. Hoffman
  2008-02-13 13:06 ` Mark M. Hoffman
  2008-02-13 13:53 ` Jean Delvare
  6 siblings, 0 replies; 8+ messages in thread
From: Mark M. Hoffman @ 2008-02-13 12:57 UTC (permalink / raw)
  To: lm-sensors

Hi:

* Juerg Haefliger <juergh@gmail.com> [2008-02-09 23:06:56 -0800]:
> Looks good - assuming the bit positions are correct, which I can't
> verify without a datasheet - and compiles cleanly.
> 
> Acked-by: Juerg Haefliger <juergh at gmail.com>
> 
> 
> > The new libsensors needs these individual alarm files.
> >
> > Signed-off-by: Jean Delvare <khali at linux-fr.org>
> > Cc: Roger Lucas <roger at planbit.co.uk>
> > ---
> > Roger, can you please test and/or review this patch?
> >
> >   drivers/hwmon/vt8231.c |   40 ++++++++++++++++++++++++++++++++++++++--
> >   1 file changed, 38 insertions(+), 2 deletions(-)

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
                   ` (4 preceding siblings ...)
  2008-02-13 12:57 ` Mark M. Hoffman
@ 2008-02-13 13:06 ` Mark M. Hoffman
  2008-02-13 13:53 ` Jean Delvare
  6 siblings, 0 replies; 8+ messages in thread
From: Mark M. Hoffman @ 2008-02-13 13:06 UTC (permalink / raw)
  To: lm-sensors

Hi:

> On Thu, 17 Jan 2008 00:05:28 -0000, Roger Lucas wrote:
> > My mail address is changing soon so I have a patch below to correct
> > my e-mail addresses in the source code.  I have a special address for
> > the vt8231 kernel development so that I can filter the spam on it more
> > aggressively - it does seem to get heavily harvested...
> > (...)
> > Signed-off-by: Roger Lucas <vt8231@hiddenengine.co.uk>
> > 
> > --- linux-2.6.24-rc8-orig/drivers/hwmon/vt8231.c        2008-01-16 22:59:25.000000000 +0000
> > +++ linux-2.6.24-rc8/drivers/hwmon/vt8231.c     2008-01-16 23:57:27.000000000 +0000
> > @@ -2,7 +2,7 @@
> >         vt8231.c - Part of lm_sensors, Linux kernel modules
> >                                 for hardware monitoring
> > 
> > -       Copyright (c) 2005 Roger Lucas <roger@planbit.co.uk>
> > +       Copyright (c) 2005 Roger Lucas <vt8231@hiddenengine.co.uk>
> >         Copyright (c) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
> >                            Aaron M. Marsh <amarsh@sdf.lonestar.org>
> > 
> > @@ -999,7 +999,7 @@
> >         }
> >  }
> > 
> > -MODULE_AUTHOR("Roger Lucas <roger@planbit.co.uk>");
> > +MODULE_AUTHOR("Roger Lucas <vt8231@hiddenengine.co.uk>");
> >  MODULE_DESCRIPTION("VT8231 sensors");
> >  MODULE_LICENSE("GPL");

* Jean Delvare <khali@linux-fr.org> [2008-01-17 12:35:19 +0100]:
> You probably want to update your address in MAINTAINERS as well.

Here's what I applied... no need to ACK, but let me know if I somehow
screwed it up.

commit 8ce37033ec889deda806384a39787deb516cf501
Author: Roger Lucas <vt8231@hiddenengine.co.uk>
Date:   Wed Feb 13 07:52:06 2008 -0500

    hwmon: (vt8231) Update maintainer email address
    
    Signed-off-by: Roger Lucas <vt8231@hiddenengine.co.uk>
    
    (modified MAINTAINERS entry also - MMH)
    
    Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>

diff --git a/MAINTAINERS b/MAINTAINERS
index c40f0ae..d3f36f4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4259,7 +4259,7 @@ S:	Maintained
 
 VT8231 HARDWARE MONITOR DRIVER
 P:	Roger Lucas
-M:	roger@planbit.co.uk
+M:	vt8231@hiddenengine.co.uk
 L:	lm-sensors@lm-sensors.org
 S:	Maintained
 
diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
index ed4b898..5bc5727 100644
--- a/drivers/hwmon/vt8231.c
+++ b/drivers/hwmon/vt8231.c
@@ -2,7 +2,7 @@
 	vt8231.c - Part of lm_sensors, Linux kernel modules
 				for hardware monitoring
 
-	Copyright (c) 2005 Roger Lucas <roger@planbit.co.uk>
+	Copyright (c) 2005 Roger Lucas <vt8231@hiddenengine.co.uk>
 	Copyright (c) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
 			   Aaron M. Marsh <amarsh@sdf.lonestar.org>
 
@@ -999,7 +999,7 @@ static void __exit sm_vt8231_exit(void)
 	}
 }
 
-MODULE_AUTHOR("Roger Lucas <roger@planbit.co.uk>");
+MODULE_AUTHOR("Roger Lucas <vt8231@hiddenengine.co.uk>");
 MODULE_DESCRIPTION("VT8231 sensors");
 MODULE_LICENSE("GPL");
 
-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] hwmon: (vt8231) Add individual alarm files
  2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
                   ` (5 preceding siblings ...)
  2008-02-13 13:06 ` Mark M. Hoffman
@ 2008-02-13 13:53 ` Jean Delvare
  6 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2008-02-13 13:53 UTC (permalink / raw)
  To: lm-sensors

On Wed, 13 Feb 2008 08:06:33 -0500, Mark M. Hoffman wrote:
> Hi:
> 
> > On Thu, 17 Jan 2008 00:05:28 -0000, Roger Lucas wrote:
> > > My mail address is changing soon so I have a patch below to correct
> > > my e-mail addresses in the source code.  I have a special address for
> > > the vt8231 kernel development so that I can filter the spam on it more
> > > aggressively - it does seem to get heavily harvested...
> > > (...)
> > > Signed-off-by: Roger Lucas <vt8231@hiddenengine.co.uk>
> > > 
> > > --- linux-2.6.24-rc8-orig/drivers/hwmon/vt8231.c        2008-01-16 22:59:25.000000000 +0000
> > > +++ linux-2.6.24-rc8/drivers/hwmon/vt8231.c     2008-01-16 23:57:27.000000000 +0000
> > > @@ -2,7 +2,7 @@
> > >         vt8231.c - Part of lm_sensors, Linux kernel modules
> > >                                 for hardware monitoring
> > > 
> > > -       Copyright (c) 2005 Roger Lucas <roger@planbit.co.uk>
> > > +       Copyright (c) 2005 Roger Lucas <vt8231@hiddenengine.co.uk>
> > >         Copyright (c) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
> > >                            Aaron M. Marsh <amarsh@sdf.lonestar.org>
> > > 
> > > @@ -999,7 +999,7 @@
> > >         }
> > >  }
> > > 
> > > -MODULE_AUTHOR("Roger Lucas <roger@planbit.co.uk>");
> > > +MODULE_AUTHOR("Roger Lucas <vt8231@hiddenengine.co.uk>");
> > >  MODULE_DESCRIPTION("VT8231 sensors");
> > >  MODULE_LICENSE("GPL");
> 
> * Jean Delvare <khali@linux-fr.org> [2008-01-17 12:35:19 +0100]:
> > You probably want to update your address in MAINTAINERS as well.
> 
> Here's what I applied... no need to ACK, but let me know if I somehow
> screwed it up.
> 
> commit 8ce37033ec889deda806384a39787deb516cf501
> Author: Roger Lucas <vt8231@hiddenengine.co.uk>
> Date:   Wed Feb 13 07:52:06 2008 -0500
> 
>     hwmon: (vt8231) Update maintainer email address
>     
>     Signed-off-by: Roger Lucas <vt8231@hiddenengine.co.uk>
>     
>     (modified MAINTAINERS entry also - MMH)
>     
>     Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c40f0ae..d3f36f4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4259,7 +4259,7 @@ S:	Maintained
>  
>  VT8231 HARDWARE MONITOR DRIVER
>  P:	Roger Lucas
> -M:	roger@planbit.co.uk
> +M:	vt8231@hiddenengine.co.uk
>  L:	lm-sensors@lm-sensors.org
>  S:	Maintained
>  
> diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
> index ed4b898..5bc5727 100644
> --- a/drivers/hwmon/vt8231.c
> +++ b/drivers/hwmon/vt8231.c
> @@ -2,7 +2,7 @@
>  	vt8231.c - Part of lm_sensors, Linux kernel modules
>  				for hardware monitoring
>  
> -	Copyright (c) 2005 Roger Lucas <roger@planbit.co.uk>
> +	Copyright (c) 2005 Roger Lucas <vt8231@hiddenengine.co.uk>
>  	Copyright (c) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
>  			   Aaron M. Marsh <amarsh@sdf.lonestar.org>
>  
> @@ -999,7 +999,7 @@ static void __exit sm_vt8231_exit(void)
>  	}
>  }
>  
> -MODULE_AUTHOR("Roger Lucas <roger@planbit.co.uk>");
> +MODULE_AUTHOR("Roger Lucas <vt8231@hiddenengine.co.uk>");
>  MODULE_DESCRIPTION("VT8231 sensors");
>  MODULE_LICENSE("GPL");
>  

Looks OK to me.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-02-13 13:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-06 14:46 [lm-sensors] hwmon: (vt8231) Add individual alarm files Jean Delvare
2008-01-06 17:22 ` Roger Lucas
2008-01-17  0:05 ` Roger Lucas
2008-01-17 11:35 ` Jean Delvare
2008-02-10  7:06 ` Juerg Haefliger
2008-02-13 12:57 ` Mark M. Hoffman
2008-02-13 13:06 ` Mark M. Hoffman
2008-02-13 13:53 ` Jean Delvare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.