Re: [PATCH] Add support for SDK7780 board

[Paul Mundt <lethal@linux-sh.org>]

On Fri, Jan 18, 2008 at 11:19:22AM +0900, Magnus Damm wrote:
> On Jan 18, 2008 12:49 AM, Nicholas Beck <nbeck@mpc-data.co.uk> wrote:
> > Add support for Renesas Technology Europe SDK7780 board.
> 
> Great, thank you for your patch!
> 
> > Signed-off-by: Nicholas Beck <nbeck@mpc-data.co.uk>
> > ---
> > diff -urN -x '.git*' a/arch/sh/boards/renesas/sdk7780/irq.c
> > b/arch/sh/boards/renesas/sdk7780/irq.c
> > --- a/arch/sh/boards/renesas/sdk7780/irq.c    1970-01-01
> > 01:00:00.000000000 +0100
> > +++ b/arch/sh/boards/renesas/sdk7780/irq.c    2008-01-17
> > 15:11:09.000000000 +0000
> > @@ -0,0 +1,102 @@
> > +/*
> > + * linux/arch/sh/boards/renesas/sdk7780/irq.c
> > + *
> > + * Renesas Technology Europe SDK7780 Support.
> > + *
> > + * Copyright (C) 2008  Nicholas Beck <nbeck@mpc-data.co.uk>
> > + *
> > + * Based on linux/arch/sh/boards/renesas/r7780rp/irq.c
> 
> This must be based on a not-so-recent kernel version. Newer kernels
> use intc tables for both cpu specific and board specific irq setup.
> Please consider updating the interrupt code - have a look at r7780mp
> or r2d for good examples.
> 
Indeed. Also the IRQ 14 handling looks pretty suspicious. It looks like
you want to have a secondary handler for this that just sets itself up as
a chained handler, as it obviously has differing semantics from the rest
of the vectors.