From: Simon Horman <horms@verge.net.au>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
kexec@lists.infradead.org, Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C
Date: Fri, 18 Jan 2008 18:11:31 +0900 [thread overview]
Message-ID: <20080118091129.GE10957@verge.net.au> (raw)
In-Reply-To: <1200377149.3505.51.camel@caritas-dev.intel.com>
On Tue, Jan 15, 2008 at 02:05:49PM +0800, Huang, Ying wrote:
> This patch transforms the kexec page tables setup code from assembler
> code to C code in machine_kexec_prepare. This improves readability and
> reduces code line number.
This looks good to me.
Simon Horman <horms@verge.net.au>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
--
Horms
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C
Date: Fri, 18 Jan 2008 18:11:31 +0900 [thread overview]
Message-ID: <20080118091129.GE10957@verge.net.au> (raw)
In-Reply-To: <1200377149.3505.51.camel@caritas-dev.intel.com>
On Tue, Jan 15, 2008 at 02:05:49PM +0800, Huang, Ying wrote:
> This patch transforms the kexec page tables setup code from assembler
> code to C code in machine_kexec_prepare. This improves readability and
> reduces code line number.
This looks good to me.
Simon Horman <horms@verge.net.au>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
--
Horms
next prev parent reply other threads:[~2008-01-18 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 6:05 [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C Huang, Ying
2008-01-15 6:05 ` Huang, Ying
2008-01-15 13:57 ` Vivek Goyal
2008-01-15 13:57 ` Vivek Goyal
2008-01-18 9:11 ` Simon Horman [this message]
2008-01-18 9:11 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118091129.GE10957@verge.net.au \
--to=horms@verge.net.au \
--cc=Ian.Campbell@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vgoyal@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.