All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
	Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: RE: [PATCH] 3.1.3 (and ??) timer_mode fix in xend for	virt-install
Date: Fri, 18 Jan 2008 15:39:55 -0700	[thread overview]
Message-ID: <20080118153955750.00000001968@djm-pc> (raw)
In-Reply-To: <20080118222050.GF25808@redhat.com>

> So either we need to make sure that 'platform' gets a default value
> set for 'timer_mode', or make the hvm_set_param() call conditional
> like
> 
>    if self.info["platform"].get("timer_mode") is not None:
>        xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
>                   long(self.info["platform"].get("timer_mode")))
> 
> I assume the Hypervisor itself already has a default timemode value,
> so making this set_param conditional is probably easiest.

Yes, this is much nicer.

Thanks,
Dan

  reply	other threads:[~2008-01-18 22:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 21:22 [PATCH] 3.1.3 (and ??) timer_mode fix in xend for virt-install Dan Magenheimer
2008-01-18 21:28 ` Keir Fraser
2008-01-18 21:41   ` Dan Magenheimer
2008-01-18 21:59     ` Daniel P. Berrange
2008-01-18 22:09       ` Keir Fraser
2008-01-18 22:13       ` Dan Magenheimer
2008-01-18 22:19         ` Keir Fraser
2008-01-18 22:20         ` Daniel P. Berrange
2008-01-18 22:39           ` Dan Magenheimer [this message]
2008-01-18 22:34       ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118153955750.00000001968@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=berrange@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.