All of lore.kernel.org
 help / color / mirror / Atom feed
From: samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH 1/4] [IrDA] Resend frames on timeout
Date: Sat, 19 Jan 2008 01:02:06 +0100	[thread overview]
Message-ID: <20080119000555.152691119@sortiz.org> (raw)
In-Reply-To: 20080119000205.827714764@sortiz.org

[-- Attachment #1: irlap_resend_ftimer.patch --]
[-- Type: text/plain, Size: 1677 bytes --]

From: Robie Basak <rb-oss-1-ptXJlWIB0NTrnbRv5XOUuA@public.gmane.org>

When final timer expires, it might also mean that the i:cmd wasn't 
received properly. If we have rejected frames, we can try to resend them.

Signed-off-by: Robie Basak <rb-oss-1-ptXJlWIB0NTrnbRv5XOUuA@public.gmane.org>
Signed-off-by: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
---
 net/irda/irlap_event.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Index: net-2.6.25/net/irda/irlap_event.c
===================================================================
--- net-2.6.25.orig/net/irda/irlap_event.c	2008-01-14 19:27:06.000000000 +0100
+++ net-2.6.25/net/irda/irlap_event.c	2008-01-17 06:33:33.000000000 +0100
@@ -1514,9 +1514,15 @@
 
 		/* N2 is the disconnect timer. Until we reach it, we retry */
 		if (self->retry_count < self->N2) {
-			/* Retry sending the pf bit to the secondary */
-			irlap_wait_min_turn_around(self, &self->qos_tx);
-			irlap_send_rr_frame(self, CMD_FRAME);
+			if (skb_peek(&self->wx_list) == NULL) {
+				/* Retry sending the pf bit to the secondary */
+				IRDA_DEBUG(4, "nrm_p: resending rr");
+				irlap_wait_min_turn_around(self, &self->qos_tx);
+				irlap_send_rr_frame(self, CMD_FRAME);
+ 			} else {
+				IRDA_DEBUG(4, "nrm_p: resend frames");
+				irlap_resend_rejected_frames(self, CMD_FRAME);
+ 			}
 
 			irlap_start_final_timer(self, self->final_timeout);
 			self->retry_count++;

-- 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-01-19  0:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-19  0:02 [PATCH 0/4] [IrDA] IrDA fixes for net-2.6.25 samuel-jcdQHdrhKHMdnm+yROfE0A
2008-01-19  0:02 ` samuel-jcdQHdrhKHMdnm+yROfE0A [this message]
2008-01-19  0:02 ` [PATCH 2/4] [IrDA] Frame length validation samuel
2008-01-19  0:02 ` [PATCH 3/4] [IrDA] Irport removal - part 1 samuel-jcdQHdrhKHMdnm+yROfE0A
2008-01-19  0:02 ` [PATCH 4/4] [IrDA] Irport removal - part 2 samuel
     [not found] ` <20080119000205.827714764-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2008-01-19  8:01   ` [PATCH 0/4] [IrDA] IrDA fixes for net-2.6.25 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080119000555.152691119@sortiz.org \
    --to=samuel-jcdqhdrhkhmdnm+yrofe0a@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.