Re: [PATCH] rcu: fix section mismatch

[Sam Ravnborg <sam@ravnborg.org>]

On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> rcu_online_cpu() should be __cpuinit instead of __devinit.
> 
> WARNING: vmlinux.o(.text+0x4b6d5): Section mismatch: reference to .init.text: (between 'rcu_cpu_notify' and 'wakeme_after_rcu')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

So if we have:
CONFIG_HOTPLUG=n
CONFIG_HOTPLUG_CPU=y

then this is a oops candidate.

Andrew - this looks like a 2.6.24 candidate.

	Sam


> ---
>  kernel/rcupdate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.24-rc8-git2.orig/kernel/rcupdate.c
> +++ linux-2.6.24-rc8-git2/kernel/rcupdate.c
> @@ -549,7 +549,7 @@ static void rcu_init_percpu_data(int cpu
>  	rdp->blimit = blimit;
>  }
>  
> -static void __devinit rcu_online_cpu(int cpu)
> +static void __cpuinit rcu_online_cpu(int cpu)
>  {
>  	struct rcu_data *rdp = &per_cpu(rcu_data, cpu);
>  	struct rcu_data *bh_rdp = &per_cpu(rcu_bh_data, cpu);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/